qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] qga/channel-posix.c: Explicitly include string.h
Date: Mon, 07 Jan 2013 18:38:13 +0100	[thread overview]
Message-ID: <50EB0805.604@weilnetz.de> (raw)
In-Reply-To: <1357579795-11770-1-git-send-email-peter.maydell@linaro.org>

Am 07.01.2013 18:29, schrieb Peter Maydell:
> Explicitly include string.h to avoid warnings under MacOS X/clang
> about implicit declarations of strerror() and strlen().
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
> I assume under Linux these are implicitly dragged in via one of the
> other headers.
>
>   qga/channel-posix.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/qga/channel-posix.c b/qga/channel-posix.c
> index d4fd628..ca9e4aa 100644
> --- a/qga/channel-posix.c
> +++ b/qga/channel-posix.c
> @@ -4,6 +4,7 @@
>   #include<unistd.h>
>   #include<fcntl.h>
>   #include<stdlib.h>
> +#include<string.h>
>   #include "qemu/osdep.h"
>   #include "qemu/sockets.h"
>   #include "qga/channel.h"
>    

Better: include qemu-common.h first and remove all
three standard includes.

- Stefan

  reply	other threads:[~2013-01-07 17:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-07 17:29 [Qemu-devel] [PATCH] qga/channel-posix.c: Explicitly include string.h Peter Maydell
2013-01-07 17:38 ` Stefan Weil [this message]
2013-01-07 17:50   ` Peter Maydell
2013-01-07 22:12     ` Eduardo Habkost
2013-01-08  5:08       ` Stefan Weil
2013-01-11  8:33 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50EB0805.604@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=patches@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).