* [Qemu-devel] [PATCH] hw/i386: Fix broken build for MinGW
@ 2013-01-04 21:57 Stefan Weil
2013-01-07 8:35 ` Gerd Hoffmann
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Weil @ 2013-01-04 21:57 UTC (permalink / raw)
To: Anthony Liguori
Cc: Lucas Meneghel Rodrigues, Stefan Weil, Marcelo Tosatti,
Gerd Hoffmann, qemu-devel
pc-testdev.c cannot be compiled with MinGW:
CC i386-softmmu/hw/i386/../pc-testdev.o
hw/i386/../pc-testdev.c:38:22: warning: sys/mman.h: file not found
hw/i386/../pc-testdev.c: In function ‘test_flush_page’:
hw/i386/../pc-testdev.c:103: warning: implicit declaration of function ‘mprotect’
...
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
hw/i386/Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
index 025803a..8f17763 100644
--- a/hw/i386/Makefile.objs
+++ b/hw/i386/Makefile.objs
@@ -12,6 +12,6 @@ obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen-host-pci-device.o
obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o
obj-y += kvm/
obj-$(CONFIG_SPICE) += qxl.o qxl-logger.o qxl-render.o
-obj-y += pc-testdev.o
+obj-$(CONFIG_KVM) += pc-testdev.o
obj-y := $(addprefix ../,$(obj-y))
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/i386: Fix broken build for MinGW
2013-01-04 21:57 [Qemu-devel] [PATCH] hw/i386: Fix broken build for MinGW Stefan Weil
@ 2013-01-07 8:35 ` Gerd Hoffmann
2013-01-07 17:16 ` Stefan Weil
0 siblings, 1 reply; 4+ messages in thread
From: Gerd Hoffmann @ 2013-01-07 8:35 UTC (permalink / raw)
To: Stefan Weil
Cc: Lucas Meneghel Rodrigues, Anthony Liguori, Marcelo Tosatti,
qemu-devel
On 01/04/13 22:57, Stefan Weil wrote:
> pc-testdev.c cannot be compiled with MinGW:
>
> CC i386-softmmu/hw/i386/../pc-testdev.o
> hw/i386/../pc-testdev.c:38:22: warning: sys/mman.h: file not found
> hw/i386/../pc-testdev.c: In function ‘test_flush_page’:
> hw/i386/../pc-testdev.c:103: warning: implicit declaration of function ‘mprotect’
> ...
> +obj-$(CONFIG_KVM) += pc-testdev.o
CONFIG_POSIX is the better choice I think.
cheers,
Gerd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/i386: Fix broken build for MinGW
2013-01-07 8:35 ` Gerd Hoffmann
@ 2013-01-07 17:16 ` Stefan Weil
2013-01-07 18:14 ` Lucas Meneghel Rodrigues
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Weil @ 2013-01-07 17:16 UTC (permalink / raw)
To: Gerd Hoffmann
Cc: Lucas Meneghel Rodrigues, Anthony Liguori, Marcelo Tosatti,
qemu-devel
Am 07.01.2013 09:35, schrieb Gerd Hoffmann:
> On 01/04/13 22:57, Stefan Weil wrote:
>> pc-testdev.c cannot be compiled with MinGW:
>>
>> CC i386-softmmu/hw/i386/../pc-testdev.o
>> hw/i386/../pc-testdev.c:38:22: warning: sys/mman.h: file not found
>> hw/i386/../pc-testdev.c: In function ‘test_flush_page’:
>> hw/i386/../pc-testdev.c:103: warning: implicit declaration of function ‘mprotect’
>> ...
>
>> +obj-$(CONFIG_KVM) += pc-testdev.o
>
> CONFIG_POSIX is the better choice I think.
>
> cheers,
> Gerd
I agree.
This patch was superseded by a newer one which indeed uses
CONFIG_POSIX and was applied by Blue, see
http://patchwork.ozlabs.org/patch/209653/
Cheers,
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/i386: Fix broken build for MinGW
2013-01-07 17:16 ` Stefan Weil
@ 2013-01-07 18:14 ` Lucas Meneghel Rodrigues
0 siblings, 0 replies; 4+ messages in thread
From: Lucas Meneghel Rodrigues @ 2013-01-07 18:14 UTC (permalink / raw)
To: Stefan Weil; +Cc: Anthony Liguori, Marcelo Tosatti, Gerd Hoffmann, qemu-devel
On 01/07/2013 03:16 PM, Stefan Weil wrote:
> Am 07.01.2013 09:35, schrieb Gerd Hoffmann:
>> On 01/04/13 22:57, Stefan Weil wrote:
>>> pc-testdev.c cannot be compiled with MinGW:
>>>
>>> CC i386-softmmu/hw/i386/../pc-testdev.o
>>> hw/i386/../pc-testdev.c:38:22: warning: sys/mman.h: file not found
>>> hw/i386/../pc-testdev.c: In function ‘test_flush_page’:
>>> hw/i386/../pc-testdev.c:103: warning: implicit declaration of
>>> function ‘mprotect’
>>> ...
>>
>>> +obj-$(CONFIG_KVM) += pc-testdev.o
>>
>> CONFIG_POSIX is the better choice I think.
>>
>> cheers,
>> Gerd
>
> I agree.
>
> This patch was superseded by a newer one which indeed uses
> CONFIG_POSIX and was applied by Blue, see
>
> http://patchwork.ozlabs.org/patch/209653/
>
> Cheers,
> Stefan
Ok, sorry about that, guys, and thanks for fixing things.
Lucas
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-07 18:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-04 21:57 [Qemu-devel] [PATCH] hw/i386: Fix broken build for MinGW Stefan Weil
2013-01-07 8:35 ` Gerd Hoffmann
2013-01-07 17:16 ` Stefan Weil
2013-01-07 18:14 ` Lucas Meneghel Rodrigues
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).