From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsHyd-000690-Vr for qemu-devel@nongnu.org; Mon, 07 Jan 2013 14:03:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsHyc-0003GY-AW for qemu-devel@nongnu.org; Mon, 07 Jan 2013 14:03:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3394) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsHyc-0003GD-38 for qemu-devel@nongnu.org; Mon, 07 Jan 2013 14:03:14 -0500 Message-ID: <50EB1B8E.6080509@redhat.com> Date: Mon, 07 Jan 2013 12:01:34 -0700 From: Eric Blake MIME-Version: 1.0 References: <1357466820-12860-1-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1357466820-12860-1-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigCBEC14AE8EE3FD8C79038EE0" Subject: Re: [Qemu-devel] [RFC PATCH 0/3] Time resync support by qemu-ga List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigCBEC14AE8EE3FD8C79038EE0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/06/2013 03:06 AM, Lei Li wrote: > This patch series attempts to add time resync support > to qemu-ga by introducing qemu-ga commands guest-get-time > and guest-set-time. >=20 >=20 > The interface for these commands like: >=20 > { 'command': 'guest-get-time', 'returns': 'HostTimeInfo' } >=20 > { 'command': 'guest-set-time', > 'data': { '*seconds': 'int', '*microseconds': 'int', > '*utc-offset': 'int' } } Why are these fields marked optional? I guess I'll find out in the actual patch, but at first glance, I think all three would be mandatory. >=20 > TODO: > This is a RFC version with POSIX-specific command implemented. > I just test on Linux guest, will add win32-specific command to > support Windows guest later. Since I want to make sure if this > seems like the way we should be headed. I hope that you just meant that you are lacking a win32 implementation of the command, but that when it is implemented, it will still use the same interface. That is, even though windows itself doesn't use POSIX time, and has a different Epoch than Jan 1 1970, such differences should be transparent to the user, who should always pass a POSIX timestamp through the interface. What we don't want is two different commands, where the management app then has to know whether the guest is Unix or Windows based, to know which of the two commands to send. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigCBEC14AE8EE3FD8C79038EE0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ6xuOAAoJEKeha0olJ0NqVt4H+wStCiCM/IBmKod/vWKthZCz YjFDILVAk5ic1rLo/OOATGa7m4aEoMW/ZTjXurk4omAlatnGQ5stTk7IgakdPI9Y rJb7j8Qbo5JnIElOQmGs2cminX3yNqW39RWtVQtPXJACWCwpQEJpS26LcWdhh+Ba hvO3uGOcMmJGCimpeweyfINeECt4K5JApGVIln9n3tVcwRJZdBygB46qT/Bn7lGB bCJmg+8iINm5NkHSioPU6++FOwbDXDQrfrJzTIAIRAna8kLalwPhpKGt19Bcxyer 8OMM+bf7gxciZnHNaSkap5HEr5D44j2qO5LRZOxltoGGjARVySnlfTDzoqMCBME= =uoXH -----END PGP SIGNATURE----- --------------enigCBEC14AE8EE3FD8C79038EE0--