From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] qdev: obey no_user
Date: Mon, 07 Jan 2013 21:40:27 +0100 [thread overview]
Message-ID: <50EB32BB.5040302@de.ibm.com> (raw)
In-Reply-To: <874nisvlfv.fsf@codemonkey.ws>
On 07/01/13 20:32, Anthony Liguori wrote:
> Christian Borntraeger <borntraeger@de.ibm.com> writes:
>
>> since
>>
>> commit 18b6dade8c0799c48f5c5e124b8c407cd5e22e96
>> qdev: refactor device creation to allow bus_info to be set only in class
>>
>> A user can specify a device that is no_user.
>> For example on my i386 box, I can add a 2nd kvmvapic device.
>>
>> This patch checks for no-user and rejects the device_add.
>>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>
> I specifically broke this when QOM was introduced because no_user
> precludes a management tool from constructing a machine directlt.
Breaking it but leaving it in the code doesnt seem to be the right thing.
The commit message from 18b6dade doesnt give any hint that this is now
broken and nobody audited the callers of no_user that they handle things
gracefully.
So whats the plan? Totally remove no_user tree-wide?
Christian
next prev parent reply other threads:[~2013-01-07 20:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 16:00 [Qemu-devel] [PATCH] qdev: obey no_user Christian Borntraeger
2013-01-07 14:05 ` Christian Borntraeger
2013-01-07 14:20 ` Andreas Färber
2013-01-07 15:24 ` Luiz Capitulino
2013-01-07 19:32 ` Anthony Liguori
2013-01-07 19:40 ` Peter Maydell
2013-01-07 20:12 ` Anthony Liguori
2013-01-07 20:16 ` Peter Maydell
2013-01-07 20:48 ` Anthony Liguori
2013-01-07 22:10 ` Andreas Färber
2013-01-07 22:20 ` Peter Maydell
2013-01-07 22:36 ` Andreas Färber
2013-01-07 22:48 ` Anthony Liguori
2013-01-07 20:40 ` Christian Borntraeger [this message]
2013-01-07 21:43 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EB32BB.5040302@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).