Re: [Qemu-devel] [PATCH 08/11] qmp: add interface query-snapshot

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]

On 12/29/2012 01:45 AM, Wenchao Xia wrote:
>   This interface now return valid internal snapshots.
> 
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
>  block.c          |   32 ++++++++++++++++++++++++++++++++
>  qapi-schema.json |   12 ++++++++++++
>  2 files changed, 44 insertions(+), 0 deletions(-)
> 

> +++ b/block.c
> @@ -2892,6 +2892,38 @@ SnapshotInfoList *bdrv_query_snapshot_infolist(BlockDriverState *bs,
>      return head;
>  }
>  
> +/* check if sn exist on all block devices, 0 means valid */

s/exist/exists/

> +++ b/qapi-schema.json
> @@ -731,6 +731,18 @@
>  { 'command': 'query-image', 'returns': ['ImageInfo'] }
>  
>  ##
> +# @query-snapshot:
> +#
> +# Get a list of valid Snapshots of virtual machine. Note that only valid
> +# internal snapshot will be returned now, inconsitent one will not be returned.

s/snapshot/snapshots/; s/ now//; s/inconsitent one/inconsistent ones/

> +#
> +# Returns: a list of @SnapshotInfo describing virtual machine snapshot.

s/describing virtual machine snapshot/describing all consistent virtual
machine snapshots/

> +#
> +# Since: 1.4
> +##
> +{ 'command': 'query-snapshot', 'returns': ['SnapshotInfo'] }
> +

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]