From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsKNB-00082F-4p for qemu-devel@nongnu.org; Mon, 07 Jan 2013 16:36:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsKN8-000535-Oo for qemu-devel@nongnu.org; Mon, 07 Jan 2013 16:36:45 -0500 Received: from mail-oa0-f47.google.com ([209.85.219.47]:46113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsKN8-00052y-Je for qemu-devel@nongnu.org; Mon, 07 Jan 2013 16:36:42 -0500 Received: by mail-oa0-f47.google.com with SMTP id h1so18842776oag.34 for ; Mon, 07 Jan 2013 13:36:41 -0800 (PST) Sender: Richard Henderson Message-ID: <50EB3FE5.9050504@twiddle.net> Date: Mon, 07 Jan 2013 13:36:37 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1357591119-40326-1-git-send-email-nickolai@csail.mit.edu> In-Reply-To: <1357591119-40326-1-git-send-email-nickolai@csail.mit.edu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] readline: avoid memcpy() of overlapping regions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nickolai Zeldovich Cc: qemu-devel@nongnu.org, Stefan Hajnoczi On 01/07/2013 12:38 PM, Nickolai Zeldovich wrote: > memcpy() for overlapping regions is undefined behavior; use memmove() > instead in readline_hist_add(). > > Signed-off-by: Nickolai Zeldovich > --- > readline.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This probably should go in via trivial... Reviewed-by: Richard Henderson r~