From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsKoF-0003nr-KM for qemu-devel@nongnu.org; Mon, 07 Jan 2013 17:04:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsKoE-0004M2-Af for qemu-devel@nongnu.org; Mon, 07 Jan 2013 17:04:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsKoE-0004Ks-1n for qemu-devel@nongnu.org; Mon, 07 Jan 2013 17:04:42 -0500 Message-ID: <50EB4676.6030208@redhat.com> Date: Mon, 07 Jan 2013 15:04:38 -0700 From: Eric Blake MIME-Version: 1.0 References: <1357466820-12860-1-git-send-email-lilei@linux.vnet.ibm.com> <1357466820-12860-3-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1357466820-12860-3-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig4C61A0785719EF2902043B0F" Subject: Re: [Qemu-devel] [PATCH 2/3] qga: add guest-get-time command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4C61A0785719EF2902043B0F Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/06/2013 03:06 AM, Lei Li wrote: > Signed-off-by: Lei Li > --- > qga/commands-posix.c | 12 ++++++++++++ > qga/qapi-schema.json | 17 +++++++++++++++++ > 2 files changed, 29 insertions(+), 0 deletions(-) >=20 > +++ b/qga/qapi-schema.json > @@ -100,6 +100,23 @@ > 'utc-offset': 'int' } } > =20 > ## > +# @guest-get-time: > +# > +# Get the information about host time in UTC and the > +# UTC offset. About the host time, or about the guest time? In other words, doesn't this command exist for the host to ask the guest what time the _guest_ thinks it is, so that the host can then decide whether to issue a followup command to tell the guest to adjust its time? > +# > +# This command tries to get the host time which is > +# presumably correct, since need to be able to resynchronize > +# clock to host in guest. > +# > +# Returns: @HostTimeInfo on success. For that matter, should we name the type in patch 1/3 'TimeInfo', instead of 'HostTimeInfo', as it is not intrinsically tied to host or guest, but more a function of who is being queried? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig4C61A0785719EF2902043B0F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ60Z2AAoJEKeha0olJ0NqeQwH/21eE/8qeFZRRsW+O9YHNZXa rODENOLMmQsn3irqDwXyjx5ZEI3+oOqxLm8vmY8vjpId/1CeYrWKcAaNCHLSFrm0 0gPovDc/SX6h4pSF4GkCo2pfWsd/GQaElFu5Ovd01SuD3ugVG60x5k5F0Lob8o6L ggMh56HTXAlVyfSj3VdetAWUpe38/VGHf5AC21tGGkEM0cL3qqOFd43AjrIjk+Yw ROwK+4WfmIV775Yay7X9Ux81DJpT3XuDm6Tg84dt5dMYBctL5V1LAhHgwAT8B0xD tpcqWgIuMHK65Bsu/xoNNLb4JYtRmLfS7KGistKWORxS3v0L3JWe4ckajLLrSdA= =qnMO -----END PGP SIGNATURE----- --------------enig4C61A0785719EF2902043B0F--