From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsOwT-0004rP-MW for qemu-devel@nongnu.org; Mon, 07 Jan 2013 21:29:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsOwS-0000KQ-H8 for qemu-devel@nongnu.org; Mon, 07 Jan 2013 21:29:29 -0500 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:43903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsOwR-0000KJ-VP for qemu-devel@nongnu.org; Mon, 07 Jan 2013 21:29:28 -0500 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 8 Jan 2013 12:27:59 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 7CB0F2BB004A for ; Tue, 8 Jan 2013 13:29:23 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r082HtNT51970234 for ; Tue, 8 Jan 2013 13:17:55 +1100 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r082TM8P030415 for ; Tue, 8 Jan 2013 13:29:23 +1100 Message-ID: <50EB8483.7080608@linux.vnet.ibm.com> Date: Tue, 08 Jan 2013 10:29:23 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1356770725-4804-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1356770725-4804-9-git-send-email-xiawenc@linux.vnet.ibm.com> <50EB3C50.7010908@redhat.com> In-Reply-To: <50EB3C50.7010908@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 08/11] qmp: add interface query-snapshot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, aliguori@us.ibm.com, phrdina@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com Sorry for bad spelling, will fix them in next version. > On 12/29/2012 01:45 AM, Wenchao Xia wrote: >> This interface now return valid internal snapshots. >> >> Signed-off-by: Wenchao Xia >> --- >> block.c | 32 ++++++++++++++++++++++++++++++++ >> qapi-schema.json | 12 ++++++++++++ >> 2 files changed, 44 insertions(+), 0 deletions(-) >> > >> +++ b/block.c >> @@ -2892,6 +2892,38 @@ SnapshotInfoList *bdrv_query_snapshot_infolist(BlockDriverState *bs, >> return head; >> } >> >> +/* check if sn exist on all block devices, 0 means valid */ > > s/exist/exists/ > >> +++ b/qapi-schema.json >> @@ -731,6 +731,18 @@ >> { 'command': 'query-image', 'returns': ['ImageInfo'] } >> >> ## >> +# @query-snapshot: >> +# >> +# Get a list of valid Snapshots of virtual machine. Note that only valid >> +# internal snapshot will be returned now, inconsitent one will not be returned. > > s/snapshot/snapshots/; s/ now//; s/inconsitent one/inconsistent ones/ > >> +# >> +# Returns: a list of @SnapshotInfo describing virtual machine snapshot. > > s/describing virtual machine snapshot/describing all consistent virtual > machine snapshots/ > >> +# >> +# Since: 1.4 >> +## >> +{ 'command': 'query-snapshot', 'returns': ['SnapshotInfo'] } >> + > -- Best Regards Wenchao Xia