From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57380)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gaowanlong@cn.fujitsu.com>) id 1TsV97-0008Mz-2v
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 04:06:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gaowanlong@cn.fujitsu.com>) id 1TsV95-0005FQ-L3
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 04:06:57 -0500
Received: from [222.73.24.84] (port=46145 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gaowanlong@cn.fujitsu.com>) id 1TsV95-0005ER-At
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 04:06:55 -0500
Message-ID: <50EBE1BE.3000500@cn.fujitsu.com>
Date: Tue, 08 Jan 2013 17:07:10 +0800
From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
MIME-Version: 1.0
References: <1356690724-37891-1-git-send-email-jasowang@redhat.com>
	<1356690724-37891-11-git-send-email-jasowang@redhat.com>
In-Reply-To: <1356690724-37891-11-git-send-email-jasowang@redhat.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH 10/12] virtio-net: multiqueue support
Reply-To: gaowanlong@cn.fujitsu.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jason Wang <jasowang@redhat.com>
Cc: krkumar2@in.ibm.com, aliguori@us.ibm.com, kvm@vger.kernel.org, mst@redhat.com, mprivozn@redhat.com, rusty@rustcorp.com.au, qemu-devel@nongnu.org, stefanha@redhat.com, jwhan@filewood.snu.ac.kr, shiyer@redhat.com

On 12/28/2012 06:32 PM, Jason Wang wrote:
> +    } else if (nc->peer->info->type !=  NET_CLIENT_OPTIONS_KIND_TAP) {
> +        ret = -1;
> +    } else {
> +        ret = tap_detach(nc->peer);
> +    }
> +
> +    return ret;
> +}
> +
> +static void virtio_net_set_queues(VirtIONet *n)
> +{
> +    int i;
> +
> +    for (i = 0; i < n->max_queues; i++) {
> +        if (i < n->curr_queues) {
> +            assert(!peer_attach(n, i));
> +        } else {
> +            assert(!peer_detach(n, i));

I got a assert here,
qemu-system-x86_64: /work/git/qemu/hw/virtio-net.c:330: virtio_net_set_queues: Assertion `!peer_detach(n, i)' failed.

Any thoughts?

Thanks,
Wanlong Gao

> +        }
> +    }
> +}
> +
> +static void virtio_net_set_multiqueue(VirtIONet *n, int multiqueue, int ctrl);
> +