From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsVqa-0002Mq-KR for qemu-devel@nongnu.org; Tue, 08 Jan 2013 04:51:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsVqY-0001NV-UF for qemu-devel@nongnu.org; Tue, 08 Jan 2013 04:51:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42971) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsVqY-0001NM-LD for qemu-devel@nongnu.org; Tue, 08 Jan 2013 04:51:50 -0500 Message-ID: <50EBEC20.3070805@redhat.com> Date: Tue, 08 Jan 2013 17:51:28 +0800 From: Jason Wang MIME-Version: 1.0 References: <1356690724-37891-1-git-send-email-jasowang@redhat.com> <1356690724-37891-11-git-send-email-jasowang@redhat.com> <50EBE1BE.3000500@cn.fujitsu.com> <50EBE6F5.9010300@redhat.com> <50EBEB91.8010604@cn.fujitsu.com> In-Reply-To: <50EBEB91.8010604@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/12] virtio-net: multiqueue support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: gaowanlong@cn.fujitsu.com Cc: krkumar2@in.ibm.com, aliguori@us.ibm.com, kvm@vger.kernel.org, mst@redhat.com, mprivozn@redhat.com, rusty@rustcorp.com.au, qemu-devel@nongnu.org, stefanha@redhat.com, jwhan@filewood.snu.ac.kr, shiyer@redhat.com On 01/08/2013 05:49 PM, Wanlong Gao wrote: > On 01/08/2013 05:29 PM, Jason Wang wrote: >> On 01/08/2013 05:07 PM, Wanlong Gao wrote: >>> On 12/28/2012 06:32 PM, Jason Wang wrote: >>>> + } else if (nc->peer->info->type != NET_CLIENT_OPTIONS_KIND_TAP) { >>>> + ret = -1; >>>> + } else { >>>> + ret = tap_detach(nc->peer); >>>> + } >>>> + >>>> + return ret; >>>> +} >>>> + >>>> +static void virtio_net_set_queues(VirtIONet *n) >>>> +{ >>>> + int i; >>>> + >>>> + for (i = 0; i < n->max_queues; i++) { >>>> + if (i < n->curr_queues) { >>>> + assert(!peer_attach(n, i)); >>>> + } else { >>>> + assert(!peer_detach(n, i)); >>> I got a assert here, >>> qemu-system-x86_64: /work/git/qemu/hw/virtio-net.c:330: virtio_net_set_queues: Assertion `!peer_detach(n, i)' failed. >>> >>> Any thoughts? >>> >>> Thanks, >>> Wanlong Gao >> Thanks for the testing, which steps or cases did you met this assertion, >> migration, reboot or just changing the number of virtqueues? > I use the 3.8-rc2 to test it again, I saw this tag has the multi-tap support. > > I just can't start the QEMU use -netdev tap,id=hostnet0,queues=2,fd=%d,fd=%d -device virtio-net-pci,netdev=hostnet0,id=net0,mac=52:54:00:ce:7b:29,bus=pci.0,addr=0x3 > > I pre-opened two tap fds, did I missing something? Nothing missed :) It should work. Could you please try not use fd=X and let qemu to create the file descriptors by itself? Btw, how did you create the two tap fds? Thanks > > Thanks, > Wanlong Gao > >>>> + } >>>> + } >>>> +} >>>> + >>>> +static void virtio_net_set_multiqueue(VirtIONet *n, int multiqueue, int ctrl); >>>> + >>> -- >>> To unsubscribe from this list: send the line "unsubscribe kvm" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >