From: "Andreas Färber" <afaerber@suse.de>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH 02/20] target-i386: sanitize AMD's ext2_features at realize time
Date: Tue, 08 Jan 2013 17:04:36 +0100 [thread overview]
Message-ID: <50EC4394.3060001@suse.de> (raw)
In-Reply-To: <1356724895-24118-3-git-send-email-imammedo@redhat.com>
Am 28.12.2012 21:01, schrieb Igor Mammedov:
> @@ -2062,6 +2052,17 @@ void x86_cpu_realize(Object *obj, Error **errp)
> env->cpuid_level = 7;
> }
>
> + /* On AMD CPUs, some CPUID[8000_0001].EDX bits must match the bits on
> + * CPUID[1].EDX.
> + */
> + if (env->cpuid_vendor1 == CPUID_VENDOR_AMD_1 &&
> + env->cpuid_vendor2 == CPUID_VENDOR_AMD_2 &&
> + env->cpuid_vendor3 == CPUID_VENDOR_AMD_3) {
> + env->cpuid_ext2_features &= ~CPUID_EXT2_AMD_ALIASES;
> + env->cpuid_ext2_features |= (env->cpuid_features
> + & CPUID_EXT2_AMD_ALIASES);
I've dropped the extra space above.
Andreas
> + }
> +
> if (!kvm_enabled()) {
> env->cpuid_features &= TCG_FEATURES;
> env->cpuid_ext_features &= TCG_EXT_FEATURES;
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-01-08 16:21 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-28 20:01 [Qemu-devel] [PATCH 00/20 v4] x86 CPU cleanup (wave 2) Igor Mammedov
2012-12-28 20:01 ` [Qemu-devel] [PATCH 01/20] target-i386: filter out unsupported features at realize time Igor Mammedov
2012-12-28 20:49 ` Eduardo Habkost
2012-12-28 20:01 ` [Qemu-devel] [PATCH 02/20] target-i386: sanitize AMD's ext2_features " Igor Mammedov
2013-01-08 16:04 ` Andreas Färber [this message]
2012-12-28 20:01 ` [Qemu-devel] [PATCH 03/20] target-i386: explicitly set vendor for each built-in cpudef Igor Mammedov
2012-12-28 20:01 ` [Qemu-devel] [PATCH 04/20] target-i386: setting default 'vendor' is obsolete, remove it Igor Mammedov
2012-12-28 20:01 ` [Qemu-devel] [PATCH 05/20] target-i386: move setting defaults out of cpu_x86_parse_featurestr() Igor Mammedov
2012-12-28 20:01 ` [Qemu-devel] [PATCH 06/20] target-i386: move out CPU features initialization in separate func Igor Mammedov
2012-12-28 20:01 ` [Qemu-devel] [PATCH 07/20] target-i386: cpu_x86_register() consolidate freeing resources Igor Mammedov
2012-12-28 20:01 ` [Qemu-devel] [PATCH 08/20] target-i386: move kvm_check_features_against_host() check to realize time Igor Mammedov
2012-12-28 20:01 ` [Qemu-devel] [PATCH 09/20] target-i386: add x86cpu_vendor_words2str() Igor Mammedov
2013-01-04 14:25 ` [Qemu-devel] [PATCH 09/20 v2] " Igor Mammedov
2013-01-04 15:50 ` Eduardo Habkost
2013-01-04 19:37 ` [Qemu-devel] [PATCH 09/20 v3] " Igor Mammedov
2013-01-04 20:02 ` Eduardo Habkost
2013-01-04 20:46 ` Igor Mammedov
2013-01-04 22:12 ` Eduardo Habkost
2013-01-04 22:49 ` [Qemu-devel] [PATCH 09/20 v4] " Igor Mammedov
2013-01-07 13:03 ` Eduardo Habkost
2012-12-28 20:01 ` [Qemu-devel] [PATCH 10/20] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t Igor Mammedov
2012-12-28 20:50 ` Eduardo Habkost
2012-12-28 20:01 ` [Qemu-devel] [PATCH 11/20] target-i386: remove vendor_override field from CPUX86State Igor Mammedov
2012-12-28 20:01 ` [Qemu-devel] [PATCH 12/20] target-i386: prepare cpu_x86_parse_featurestr() to return a set of key, value property pairs Igor Mammedov
2012-12-28 20:01 ` [Qemu-devel] [PATCH 13/20] target-i386: set custom 'vendor' without intermediate x86_def_t Igor Mammedov
2012-12-28 20:01 ` [Qemu-devel] [PATCH 14/20] target-i386: print deprecated warning if xlevel < 0x80000000 Igor Mammedov
2012-12-28 20:50 ` Eduardo Habkost
2012-12-28 20:01 ` [Qemu-devel] [PATCH 15/20] target-i386: set custom 'xlevel' without intermediate x86_def_t Igor Mammedov
2012-12-28 20:50 ` Eduardo Habkost
2012-12-28 20:01 ` [Qemu-devel] [PATCH 16/20] target-i386: set custom 'level' " Igor Mammedov
2012-12-28 20:01 ` [Qemu-devel] [PATCH 17/20] target-i386: set custom 'model-id' " Igor Mammedov
2012-12-28 20:01 ` [Qemu-devel] [PATCH 18/20] target-i386: set custom 'stepping' " Igor Mammedov
2012-12-28 20:01 ` [Qemu-devel] [PATCH 19/20] target-i386: set custom 'model' " Igor Mammedov
2012-12-28 20:01 ` [Qemu-devel] [PATCH 20/20] target-i386: set custom 'family' " Igor Mammedov
2013-01-08 18:21 ` [Qemu-devel] [PATCH 00/20 v4] x86 CPU cleanup (wave 2) Andreas Färber
-- strict thread matches above, loose matches on Subject: below --
2012-12-27 14:59 [Qemu-devel] [PATCH 00/20 v3] " Igor Mammedov
2012-12-27 14:59 ` [Qemu-devel] [PATCH 02/20] target-i386: sanitize AMD's ext2_features at realize time Igor Mammedov
2012-12-27 18:42 ` Eduardo Habkost
2012-12-17 16:01 [Qemu-devel] [PATCH 00/20 v2] x86 CPU cleanup (wave 2) Igor Mammedov
2012-12-17 16:01 ` [Qemu-devel] [PATCH 02/20] target-i386: sanitize AMD's ext2_features at realize time Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EC4394.3060001@suse.de \
--to=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).