qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: "Andreas Färber" <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 14/17] qemu-common.h: Make qemu_init_vcpu() stub static inline
Date: Tue, 08 Jan 2013 13:32:33 -0800	[thread overview]
Message-ID: <50EC9071.6000202@twiddle.net> (raw)
In-Reply-To: <1357678594-427-15-git-send-email-afaerber@suse.de>

On 01/08/2013 12:56 PM, Andreas Färber wrote:
> Turn the *-user macro into a no-op inline function to avoid
> unused-variable warnings and band-aiding #ifdef'ery.
> 
> This allows to drop an #ifdef for alpha and avoids more for unicore32
> and other upcoming trivial realizefn implementations.
> 
> Suggested-by: Lluís Vilanova <vilanova@ac.upc.edu>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  include/qemu-common.h |    4 +++-
>  target-alpha/cpu.c    |    2 --
>  2 Dateien geändert, 3 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~

  reply	other threads:[~2013-01-08 21:32 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-08 20:56 [Qemu-devel] [PULL] QOM CPUState patch queue 2013-01-08 Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 01/17] libqemustub: Add qemu_[un]register_reset() stubs Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 02/17] libqemustub: vmstate register/unregister stubs Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 03/17] libqemustub: sysbus_get_default() stub Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 04/17] qdev: Include qdev code into *-user, too Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 05/17] qdev: Don't assume existence of parent bus on unparenting Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 06/17] cpu: Change parent type to Device Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 07/17] target-i386: kvm: -cpu host: Use GET_SUPPORTED_CPUID for SVM features Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 08/17] target-i386: kvm: Enable all supported KVM features for -cpu host Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 09/17] target-i386: check/enforce: Fix CPUID leaf numbers on error messages Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 10/17] target-i386: check/enforce: Do not ignore "hypervisor" flag Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 11/17] target-i386: check/enforce: Check all CPUID.80000001H.EDX bits Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 12/17] target-i386: check/enforce: Check SVM flag support as well Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 13/17] target-i386: check/enforce: Eliminate check_feat field Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 14/17] qemu-common.h: Make qemu_init_vcpu() stub static inline Andreas Färber
2013-01-08 21:32   ` Richard Henderson [this message]
2013-01-08 20:56 ` [Qemu-devel] [PATCH 15/17] target-i386: Filter out unsupported features at realize time Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 16/17] target-i386: Sanitize AMD's ext2_features " Andreas Färber
2013-01-08 20:56 ` [Qemu-devel] [PATCH 17/17] target-i386: Explicitly set vendor for each built-in cpudef Andreas Färber
2013-01-08 21:56 ` [Qemu-devel] [PULL] QOM CPUState patch queue 2013-01-08 Andreas Färber
2013-01-08 22:34   ` Anthony Liguori
2013-01-08 23:40     ` Andreas Färber
2013-01-08 22:29 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50EC9071.6000202@twiddle.net \
    --to=rth@twiddle.net \
    --cc=afaerber@suse.de \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).