From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tsgml-0002RC-F2 for qemu-devel@nongnu.org; Tue, 08 Jan 2013 16:32:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tsgmi-0006i5-TY for qemu-devel@nongnu.org; Tue, 08 Jan 2013 16:32:39 -0500 Received: from mail-vc0-f178.google.com ([209.85.220.178]:40577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tsgmi-0006i1-OX for qemu-devel@nongnu.org; Tue, 08 Jan 2013 16:32:36 -0500 Received: by mail-vc0-f178.google.com with SMTP id l6so905686vcl.37 for ; Tue, 08 Jan 2013 13:32:36 -0800 (PST) Sender: Richard Henderson Message-ID: <50EC9071.6000202@twiddle.net> Date: Tue, 08 Jan 2013 13:32:33 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1357678594-427-1-git-send-email-afaerber@suse.de> <1357678594-427-15-git-send-email-afaerber@suse.de> In-Reply-To: <1357678594-427-15-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 14/17] qemu-common.h: Make qemu_init_vcpu() stub static inline List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: qemu-devel@nongnu.org, Eduardo Habkost On 01/08/2013 12:56 PM, Andreas Färber wrote: > Turn the *-user macro into a no-op inline function to avoid > unused-variable warnings and band-aiding #ifdef'ery. > > This allows to drop an #ifdef for alpha and avoids more for unicore32 > and other upcoming trivial realizefn implementations. > > Suggested-by: Lluís Vilanova > Signed-off-by: Eduardo Habkost > Signed-off-by: Andreas Färber > Reviewed-by: Eduardo Habkost > --- > include/qemu-common.h | 4 +++- > target-alpha/cpu.c | 2 -- > 2 Dateien geändert, 3 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) Reviewed-by: Richard Henderson r~