qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-ga: add ga_open_logfile()
Date: Tue, 08 Jan 2013 16:09:10 -0700	[thread overview]
Message-ID: <50ECA716.50205@redhat.com> (raw)
In-Reply-To: <1357680386-10904-3-git-send-email-lcapitulino@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

On 01/08/2013 02:26 PM, Luiz Capitulino wrote:
> This function sets O_CLOEXEC on the log file fd so that it isn't
> leaked to executed processes.
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  qga/main.c | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

  reply	other threads:[~2013-01-08 23:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-08 21:26 [Qemu-devel] [PATCH 0/2] qemu-ga: don't leak fds to exec()ed processes Luiz Capitulino
2013-01-08 21:26 ` [Qemu-devel] [PATCH 1/2] qemu-ga: ga_open_pidfile(): use qemu_open() Luiz Capitulino
2013-01-08 23:06   ` Eric Blake
2013-01-08 21:26 ` [Qemu-devel] [PATCH 2/2] qemu-ga: add ga_open_logfile() Luiz Capitulino
2013-01-08 23:09   ` Eric Blake [this message]
2013-01-09  4:13 ` [Qemu-devel] [PATCH 0/2] qemu-ga: don't leak fds to exec()ed processes Amos Kong
2013-01-10 21:24 ` mdroth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50ECA716.50205@redhat.com \
    --to=eblake@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).