From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsiUC-00051R-Up for qemu-devel@nongnu.org; Tue, 08 Jan 2013 18:21:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsiUB-0002M2-MJ for qemu-devel@nongnu.org; Tue, 08 Jan 2013 18:21:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsiUB-0002Lv-EE for qemu-devel@nongnu.org; Tue, 08 Jan 2013 18:21:35 -0500 Message-ID: <50ECA9BA.9000602@redhat.com> Date: Tue, 08 Jan 2013 16:20:26 -0700 From: Eric Blake MIME-Version: 1.0 References: <1355834518-17989-1-git-send-email-vasilis.liaskovitis@profitbricks.com> <1355834518-17989-22-git-send-email-vasilis.liaskovitis@profitbricks.com> In-Reply-To: <1355834518-17989-22-git-send-email-vasilis.liaskovitis@profitbricks.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigF0306492553DB8FA26AED53C" Subject: Re: [Qemu-devel] [RFC PATCH v4 21/30] Implement dimm-info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vasilis Liaskovitis Cc: pingfank@linux.vnet.ibm.com, gleb@redhat.com, stefanha@gmail.com, jbaron@redhat.com, seabios@seabios.org, qemu-devel@nongnu.org, blauwirbel@gmail.com, kevin@koconnor.net, kraxel@redhat.com, anthony@codemonkey.ws This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF0306492553DB8FA26AED53C Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/18/2012 05:41 AM, Vasilis Liaskovitis wrote: > "query-dimm-info" and "info dimm" will give current state of all dimms = in the > system e.g. >=20 > dimm0: on > dimm1: off > dimm2: off > dimm3: on > etc. >=20 > Signed-off-by: Vasilis Liaskovitis > --- > +++ b/qapi-schema.json > @@ -2914,6 +2914,32 @@ > { 'command': 'query-memory-total', 'returns': 'int' } > =20 > ## > +# @DimmInfo: > +# > +# Information about status of a memory hotplug command > +# > +# @dimm: the Dimm associated with the result > +# > +# @result: the result of the hotplug command Here you call it 'result', > +# > +# Since: 1.4 > +# > +## > +{ 'type': 'DimmInfo', > + 'data': {'dimm': 'str', 'state': 'bool'} } but here you call it 'state'. Which is it? And does 'true' mean plugged in, or that the last command succeeded (where the last command may have been either a plug or an unplug)? My preference is that 'true' means plugged in, so more documentation would help. > + > +## > +# @query-dimm-info: > +# > +# Returns total memory in bytes, including hotplugged dimms Really? > +# > +# Returns: int Copy-and-paste error? This doesn't return an 'int', but an array of 'DimmInfo'. > +# > +# Since: 1.4 > +## > +{ 'command': 'query-dimm-info', 'returns': ['DimmInfo'] } > + > +## > # @QKeyCode: > # > # An enumeration of key name. >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigF0306492553DB8FA26AED53C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ7Km6AAoJEKeha0olJ0NqfhIIAIG33RtWWAcUOYPjn2beUPBL tNtwqZcORdOGpy5wdvSJ7xgdzqB/JEp0xObfb/yDZeWYeoIixSUJzkFTaJcxeFAn j4V1xiMnYa8K1JFOz6aqUnFS0UpZKsgfjNFWtYV/7vTCHIbgckprqq85CL+eeuld OH48zbv/qFOhgG5DIIItwebQByK5Wz96ZE0fsVs3dt3JblWFLN9mA00RjeFqTY3r IUPLAukcOqx4XuVEVvo9k2DNeh0OGpMvDqxMfwf6rLNkN/2NEdW93qSnKUu4W8WD gHCCbkEaNQ2RpqW18n8GnLlPm/2siztagVdZDAM2xCP6d9pxi/S/cNLOvM2SCmc= =ILCD -----END PGP SIGNATURE----- --------------enigF0306492553DB8FA26AED53C--