From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tsmem-0003cx-0U for qemu-devel@nongnu.org; Tue, 08 Jan 2013 22:48:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tsmek-0001gS-Km for qemu-devel@nongnu.org; Tue, 08 Jan 2013 22:48:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42177) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tsmek-0001gM-CA for qemu-devel@nongnu.org; Tue, 08 Jan 2013 22:48:46 -0500 Message-ID: <50ECB893.2060300@redhat.com> Date: Tue, 08 Jan 2013 17:23:47 -0700 From: Eric Blake MIME-Version: 1.0 References: <1355834518-17989-1-git-send-email-vasilis.liaskovitis@profitbricks.com> <1355834518-17989-27-git-send-email-vasilis.liaskovitis@profitbricks.com> In-Reply-To: <1355834518-17989-27-git-send-email-vasilis.liaskovitis@profitbricks.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig09511DEE6661D8964B1895A6" Subject: Re: [Qemu-devel] [RFC PATCH v4 26/30] Implement qmp and hmp commands for notification lists List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vasilis Liaskovitis Cc: pingfank@linux.vnet.ibm.com, gleb@redhat.com, stefanha@gmail.com, jbaron@redhat.com, seabios@seabios.org, qemu-devel@nongnu.org, blauwirbel@gmail.com, kevin@koconnor.net, kraxel@redhat.com, anthony@codemonkey.ws This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig09511DEE6661D8964B1895A6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/18/2012 05:41 AM, Vasilis Liaskovitis wrote: > Guest can respond to ACPI hotplug events e.g. with _EJ or _OST method. > This patch implements a tail queue to store guest notifications for mem= ory > hot-add and hot-remove requests. >=20 > Guest responses for memory hotplug command on a per-dimm basis can be d= etected > with the new hmp command "info memory-hotplug" or the new qmp command > "query-memory-hotplug" >=20 > Examples: >=20 > (qemu) device_add dimm,id=3Dram0 > (qemu) info memory-hotplug > dimm: ram0 hot-add success > or > dimm: ram0 hot-add failure >=20 > +++ b/qapi-schema.json > @@ -2940,6 +2940,32 @@ > { 'command': 'query-dimm-info', 'returns': ['DimmInfo'] } > =20 > ## > +# @MemHpInfo: > +# > +# Information about status of a memory hotplug command > +# > +# @dimm: the Dimm associated with the result Didn't document @request. > +# > +# @result: the result of the hotplug command > +# > +# Since: 1.4 > +# > +## > +{ 'type': 'MemHpInfo', > + 'data': {'dimm': 'str', 'request': 'str', 'result': 'str'} } Instead of open-coding 'request' and 'result' as an arbitrary string, it would be nicer to have them be an enum type with a finite subset of expected values. > + > +## > +# @query-memory-hotplug: > +# > +# Returns a list of information about pending hotplug commands > +# > +# Returns: a list of @MemhpInfo s/MemhpInfo/MemHpInfo/ > +# > +# Since: 1.4 > +## > +{ 'command': 'query-memory-hotplug', 'returns': ['MemHpInfo'] } > + > +## > # @QKeyCode: > # --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig09511DEE6661D8964B1895A6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ7LiTAAoJEKeha0olJ0Nqy4sH/i5Uor+wn7HKug+nj1Jk1PL4 suBwRvXKwQjiZhH17ElhnhvIwiYMUDslC3APBQXGOvLprb894reRRi7uhdCDg1gg FFqSCdf7Hz/jq6TRSX8VL4N6gXa7efFAa6Oi3EZt3oc5//6uHTT1GJf8y7XYvxxR XPD6xBQeaQE1KOSlGEnevjCziSMmEk5IFcWUTtWJganxILEQKO719llQw8L2HPGC sXZyjqKtl0QN7/e69MuSuJqQdEsqam/ClNAvuTv3ohNotm5YGTLumfGf580n+mbY cMuWP4NrAy+rjwviS17IFMpE5ohF96dyi/93EpKL+y37FjjOCCUgh9MQu3tdUEY= =1UU8 -----END PGP SIGNATURE----- --------------enig09511DEE6661D8964B1895A6--