From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsjfC-0005I1-Gn for qemu-devel@nongnu.org; Tue, 08 Jan 2013 19:37:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsjfB-000429-CE for qemu-devel@nongnu.org; Tue, 08 Jan 2013 19:37:02 -0500 Received: from cantor2.suse.de ([195.135.220.15]:52582 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tsjf6-00041O-AN for qemu-devel@nongnu.org; Tue, 08 Jan 2013 19:37:01 -0500 Message-ID: <50ECBBA2.6020500@suse.de> Date: Wed, 09 Jan 2013 01:36:50 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <4773138dce3a8e61f90ebc20837ff4a283137eb3.1357607262.git.agarcia@igalia.com> <50EC256C.5060607@suse.de> <20130108155754.GA25155@igalia.com> In-Reply-To: <20130108155754.GA25155@igalia.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 1/2] Add TEWS TPCI200 IndustryPack emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: Blue Swirl , Paolo Bonzini , Anthony Liguori , qemu-devel@nongnu.org Am 08.01.2013 16:57, schrieb Alberto Garcia: > On Tue, Jan 08, 2013 at 02:55:56PM +0100, Andreas F=E4rber wrote: >=20 >> IPACK_DEVICE() >> >> You have them defined in the header, please use them consistently. >> >> Also, please avoid accessing internals like &s->bus.qbus >> (BUS(s->bus)) or &s->dev.qdev (DEVICE(s->dev)). >=20 > Ok, I'm using all the defined macros and replaced all instances of > DO_UPCAST() with their checked equivalents. >=20 > I also removed all accesses to internals. qdev->parent_bus is not supposed to be accessed either, there is qdev_get_parent_bus() as accessor function. > And I defined ipack_bus_new_inplace() (in the spirit of > pci_bus_new_inplace()) and updated tpci200_initfn(). Note that Paolo has a series refactoring the in-place bus init (either for qdev reset or for QOM reference counting) that you may want to take into account then. Having the IPackBus not be a pointer but part of the exposing device initialized in-place would be desirable long-term but, like some other issues raised, not a criteria for initial patch acceptance IMO. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg