From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44217)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1Tsrjk-0004YC-F9
	for qemu-devel@nongnu.org; Wed, 09 Jan 2013 04:14:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1Tsrji-0002bJ-IE
	for qemu-devel@nongnu.org; Wed, 09 Jan 2013 04:14:16 -0500
Received: from greensocs.com ([87.106.252.221]:58475
	helo=s15328186.onlinehome-server.info)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1Tsrji-0002bC-8f
	for qemu-devel@nongnu.org; Wed, 09 Jan 2013 04:14:14 -0500
Message-ID: <50ED34DF.7090008@greensocs.com>
Date: Wed, 09 Jan 2013 10:14:07 +0100
From: =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= <fred.konrad@greensocs.com>
MIME-Version: 1.0
References: <1357584074-10852-1-git-send-email-fred.konrad@greensocs.com>
	<1357584074-10852-4-git-send-email-fred.konrad@greensocs.com>
	<CAFEAcA8ccjKe_D_FLyE0r=vU6JvnEpEgfo8x_s_9GDNFAzFLrw@mail.gmail.com>
	<50ED2C56.50209@greensocs.com>
In-Reply-To: <50ED2C56.50209@greensocs.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 03/61] virtio-pci-bus : introduce
	virtio-pci-bus.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, e.voevodin@samsung.com, mst@redhat.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, agraf@suse.de, amit.shah@redhat.com, aneesh.kumar@linux.vnet.ibm.com, stefanha@redhat.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com, afaerber@suse.de

On 09/01/2013 09:37, KONRAD Fr=C3=A9d=C3=A9ric wrote:
> On 08/01/2013 19:08, Peter Maydell wrote:
>> On 7 January 2013 18:40, <fred.konrad@greensocs.com> wrote:
>>> From: KONRAD Frederic <fred.konrad@greensocs.com>
>>>
>>> Introduce virtio-pci-bus, which extends virtio-bus. It is used with=20
>>> virtio-pci
>>> transport device.
>>>
>>> Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>
>> This isn't quite right, I think (somebody correct me if I'm wrong!)
>> The virtio-pci-bus subclass doesn't have any state of its own, so it
>> doesn't need a struct, but it does still want a type, so virtio-pci.h=20
>> should
>> have a
>>     typedef VirtioBusClass VirtioPCIBusClass;
>>     typedef VirtioBusState VirtioPCIBusState;
>> and we then use VirtioPCIBusClass/State where appropriate
>> (notably in the typeinfo for class/instance size and in the get-class/
>> class-check/etc macros).
>>
>> This lets us easily add state later if we need to by turning the
>> typedef into a typedef'd struct without having to hunt down all
>> the places that now need to say 'VirtioPCIBus*' rather than
>> 'VirtioBus*'.
>>
>> -- PMM
>>
> Ok, I'll make the change.
>
>
Though, I'm not really sure we will add something here..
The virtio-pci-bus is only added to implement VirtioBusClass functions.
There are no differences between pci, s390, or mmio.

unless it is mandatory to have another name in the QOM macros ?