From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TssxU-0000Is-Iz for qemu-devel@nongnu.org; Wed, 09 Jan 2013 05:32:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TssxT-0005lp-ET for qemu-devel@nongnu.org; Wed, 09 Jan 2013 05:32:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14492) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TssxT-0005lV-6P for qemu-devel@nongnu.org; Wed, 09 Jan 2013 05:32:31 -0500 Message-ID: <50ED473A.7040209@redhat.com> Date: Wed, 09 Jan 2013 11:32:26 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1357631962-10484-1-git-send-email-kraxel@redhat.com> <87mwwj22wo.fsf@codemonkey.ws> <50EC38FF.7010801@redhat.com> <87obgzzm3q.fsf@codemonkey.ws> <20130109100935.GB20716@redhat.com> In-Reply-To: <20130109100935.GB20716@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pc: rename machine types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, Anthony Liguori On 01/09/13 11:09, Daniel P. Berrange wrote: >>> I don't care that much what the actual names are. Using piix + q35 is >>> inconsistent, so it isn't that a good choice indeed. So what now? >>> >>> (1) We could go for the host bridge and use 'i440fx' + 'q35'. >>> (2) We could go for the south bridge and use 'piix' + 'ich9'. > > Either of these sound fine to me, with a slight preference for the > first option. > >>> (3) Something different? > > If we really want 'pc' in the name, then > > (4) pci440fx & pcq35 > (5) pcpiix & pcich9 A dash would improve readability, also we have isapc which has pc as postfix, so maybe 'i440fx-pc' + 'q35-pc' ? >> The issue I have with 'i440fx' and 'q35' is that it's basically >> gibberish to a non-QEMU developer. > > With my users and/or libvirt developers hat on, I don't agree really. > What Gerd suggests clearly states the hardware type being used by the > machine. I think 'pc' is pretty much meaningless as a machine name > because it can mean pretty much anything you want to it. It is akin > to just calling your network device 'nic' and your disk device 'disk', > which QEMU doesn't do for obvious reasons. Fully agree. It also follows the convention of other archs (just look at the arm machine names). cheers, Gerd