From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Anthony Liguori" <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices
Date: Wed, 09 Jan 2013 12:12:55 +0100 [thread overview]
Message-ID: <50ED50B7.4000907@redhat.com> (raw)
In-Reply-To: <20130109110926.GA17317@redhat.com>
Il 09/01/2013 12:09, Michael S. Tsirkin ha scritto:
> On Wed, Jan 09, 2013 at 11:53:00AM +0100, Paolo Bonzini wrote:
>> Il 09/01/2013 11:22, Michael S. Tsirkin ha scritto:
>>>> It's possible. I'll move the SCSI bus away from qdev reset.
>>>> Anthony/Michael, can you help doing the same with PCIDevice? And
>>>> perhaps Peter and Andreas with sysbus?
>>>
>>> I'm not sure what would you like to change with PCIDevice.
>>
>> Replace the DeviceState reset method with one in PCIDevice, and call it
>> from the PCI bus reset.
>>
>> Paolo
>
> You are talking about the call to qdev_reset_all(&dev->qdev)
> in pci_device_reset
Yes.
> , and you want to detect, there, that device is a bridge
> and replace qdev_reset_all(&dev->qdev) with cast and call to pci_bus_reset
> for the secondary bus?
The bridge would call pci_bus_reset for its secondary bus in the
PCIDevice reset method.
I.e. all bus navigation would have to be explicit in the reset
callbacks. I'm going to do that for the SCSI HBAs.
Paolo
next prev parent reply other threads:[~2013-01-09 11:13 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 16:24 [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 01/15] qdev: do not reset a device until the parent has been initialized Paolo Bonzini
2012-12-17 16:52 ` Michael S. Tsirkin
2012-12-17 16:53 ` Michael S. Tsirkin
2012-12-17 17:06 ` Paolo Bonzini
2012-12-17 21:57 ` Andreas Färber
2012-12-17 16:24 ` [Qemu-devel] [PATCH 02/15] intel-hda: do not reset codecs from intel_hda_reset Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 03/15] pci: clean up resetting of IRQs Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 04/15] virtio-pci: reset device before PCI layer Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 05/15] virtio-s390: add a reset function to virtio-s390 devices Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 06/15] qdev: add qbus_reset_all Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 07/15] pci: do not export pci_bus_reset Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 08/15] lsi: use qbus_reset_all to reset SCSI bus Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 09/15] qdev: allow both pre- and post-order vists in qdev walking functions Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 10/15] qdev: switch reset to post-order Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 11/15] qdev: remove device_reset Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 12/15] qdev: document reset semantics Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 13/15] virtio-pci: reset all qbuses too when writing to the status field Paolo Bonzini
2012-12-17 16:48 ` Michael S. Tsirkin
2012-12-17 16:54 ` Paolo Bonzini
2012-12-17 17:08 ` Michael S. Tsirkin
2012-12-17 17:09 ` Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 14/15] virtio-s390: " Paolo Bonzini
2012-12-17 16:29 ` Alexander Graf
2012-12-17 16:24 ` [Qemu-devel] [PATCH 15/15] virtio-serial: do not perform bus reset by hand Paolo Bonzini
2012-12-17 21:43 ` [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices Michael S. Tsirkin
2012-12-18 7:27 ` Paolo Bonzini
2012-12-18 8:35 ` Paolo Bonzini
2012-12-18 9:49 ` Michael S. Tsirkin
2012-12-18 11:40 ` Paolo Bonzini
2013-01-07 17:46 ` Michael S. Tsirkin
2013-01-07 19:10 ` Anthony Liguori
2013-01-07 19:57 ` Peter Maydell
2013-01-07 20:20 ` Anthony Liguori
2013-01-07 20:28 ` Peter Maydell
2013-01-07 20:51 ` Anthony Liguori
2013-01-09 9:33 ` Paolo Bonzini
2013-01-09 10:22 ` Michael S. Tsirkin
2013-01-09 10:53 ` Paolo Bonzini
2013-01-09 11:09 ` Michael S. Tsirkin
2013-01-09 11:12 ` Paolo Bonzini [this message]
2013-01-09 12:10 ` Michael S. Tsirkin
2013-01-09 17:46 ` Paolo Bonzini
2013-01-09 20:40 ` Anthony Liguori
2013-01-09 21:22 ` Paolo Bonzini
2013-01-09 21:40 ` Michael S. Tsirkin
2013-01-10 8:31 ` Paolo Bonzini
2013-01-10 11:32 ` Michael S. Tsirkin
2013-01-10 11:46 ` Peter Maydell
2013-01-10 11:47 ` Paolo Bonzini
2013-01-10 11:59 ` Peter Maydell
2013-01-10 12:12 ` Paolo Bonzini
2013-01-10 12:31 ` Peter Maydell
2013-01-10 12:45 ` Paolo Bonzini
2013-01-10 13:01 ` Peter Maydell
2013-01-10 13:32 ` Paolo Bonzini
2013-01-10 14:14 ` Anthony Liguori
2013-01-10 14:38 ` Paolo Bonzini
2013-01-10 15:01 ` Michael S. Tsirkin
2013-01-08 13:58 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2013-01-03 2:18 Anthony Liguori
2013-01-02 18:23 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ED50B7.4000907@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).