From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsxM7-0003x6-JX for qemu-devel@nongnu.org; Wed, 09 Jan 2013 10:14:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsxM2-0003uf-F5 for qemu-devel@nongnu.org; Wed, 09 Jan 2013 10:14:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsxM2-0003uY-6m for qemu-devel@nongnu.org; Wed, 09 Jan 2013 10:14:10 -0500 Message-ID: <50ED893F.50905@redhat.com> Date: Wed, 09 Jan 2013 08:14:07 -0700 From: Eric Blake MIME-Version: 1.0 References: <1357716867-1190-1-git-send-email-akong@redhat.com> <1357720753-3119-1-git-send-email-akong@redhat.com> In-Reply-To: <1357720753-3119-1-git-send-email-akong@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig01433D04C783FAA47BE102E8" Subject: Re: [Qemu-devel] [Qemu PATCH v2] add a boot option to do strict boot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: aliguori@us.ibm.com, dallan@redhat.com, gleb@redhat.com, "libvir-list@redhat.com" , seabios@seabios.org, qemu-devel@nongnu.org, kevin@koconnor.net This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig01433D04C783FAA47BE102E8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/09/2013 01:39 AM, Amos Kong wrote: > Current seabios will try to boot from selected devices first, > if they are all failed, seabios will also try to boot from > un-selected devices. >=20 > We need to make it configurable. I already posted a seabios > patch to add a new device type to halt booting. Qemu can add > "HALT" at the end of bootindex string, then seabios will halt > booting after trying to boot from selected devices. >=20 > This option only effects when boot priority is changed by > bootindex options, the old style(-boot order=3D..) will still > try to boot from un-selected devices. >=20 > v2: add HALT entry in get_boot_devices_list() > define boot_strict to bool >=20 > Signed-off-by: Amos Kong > --- Libvirt will need to expose an attribute that lets the user control whether to use this new option; how do we probe via QMP whether the new -boot strict=3Don command-line option is available? > +++ b/qemu-options.hx > @@ -376,14 +376,14 @@ ETEXI > =20 > DEF("boot", HAS_ARG, QEMU_OPTION_boot, > "-boot [order=3Ddrives][,once=3Ddrives][,menu=3Don|off]\n" > - " [,splash=3Dsp_name][,splash-time=3Dsp_time][,reboot-timeout= =3Drb_time]\n" > + " [,splash=3Dsp_name][,splash-time=3Dsp_time][,reboot-timeout= =3Drb_time][,strict=3Don|off]\n" > " 'drives': floppy (a), hard disk (c), CD-ROM (d), = network (n)\n" > " 'sp_name': the file's name that would be passed t= o bios as logo picture, if menu=3Don\n" > " 'sp_time': the period that splash picture last if= menu=3Don, unit is ms\n" > " 'rb_timeout': the timeout before guest reboot whe= n boot failed, unit is ms\n", So if I understand correctly, -boot order=3D... is incompatible with -boo= t strict=3Don; even though you have listed both options under a single -boo= t entry in the -help. We've already declared that -help output is no longer guaranteed stable, so this doesn't really impact libvirt, but would it make any more sense to list this as two orthogonal entries, to make it clear that they don't mix? -boot order=3Ddrivers[,once=3Ddrives]... -boot strict=3Don|off[,menu=3Don|off]... But this is all bikeshedding, so it's not worth a v3 if you disagree. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig01433D04C783FAA47BE102E8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ7Yk/AAoJEKeha0olJ0NqiYIH+gJgRMLPgAK7qlR+4qA+Z95C 0dwcXE/YA+giCxFa8OUxTmHa+bLFHTglqHIcQshD93UqXb9y9tB8wINvF3mpcBjZ yQ7WtuH1IQP57pR6rGE6z2tVkKx72/breEip+gQ/kie1DPXZB7TiKgIX1PE8g7Hp 2aEJky+pkVOsnmpcEfS3d11p2YCoO+kXDVs4cgKVWy4m2WN/c0ikwZN0qSy3Ipsi GC2YnSQmm57eDpVuQmMBN5xD091YNXIIq7GOxcb5U0Ni4mMij0Aur8cnaZunGZ+3 ySyKwgAg98xNpKQpnUW3a1oCKr2NXyL4lUY/bwbKFalp7kOfBiGvgfe+fOarbkk= =tWAe -----END PGP SIGNATURE----- --------------enig01433D04C783FAA47BE102E8--