From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tsy17-000058-3Z for qemu-devel@nongnu.org; Wed, 09 Jan 2013 10:56:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tsy12-0007Ln-6b for qemu-devel@nongnu.org; Wed, 09 Jan 2013 10:56:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tsy11-0007LY-TX for qemu-devel@nongnu.org; Wed, 09 Jan 2013 10:56:32 -0500 Message-ID: <50ED9329.40202@redhat.com> Date: Wed, 09 Jan 2013 08:56:25 -0700 From: Eric Blake MIME-Version: 1.0 References: <1357708350-9917-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1357708350-9917-4-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1357708350-9917-4-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigF55754F1AF5B49C0FCCEFC45" Subject: Re: [Qemu-devel] [PATCH V2 03/11] block: add snapshot and image info query function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: aliguori@us.ibm.com, phrdina@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF55754F1AF5B49C0FCCEFC45 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/08/2013 10:12 PM, Wenchao Xia wrote: > This patch added function bdrv_query_image_info() and > bdrv_query_snapshot_infolist(), which will return info in qmp object > format. The implemetion code are mostly copied from collect_image_info(= ) s/implemetion/implementation/ > and collect_snapshot() in qemu-img.c. > To help filter out snapshot info not needed, a call back function is > added in bdrv_query_snapshot_infolist(). >=20 > v2: Generally, the v2 information should go... > Seperate patch for adding these functions. > Spelling fix. > Coding style fix due to comments from Eric. >=20 > Signed-off-by: Wenchao Xia > --- =2E..here, after the S-o-b and --- separator. It is useful for email review, but doesn't need to clutter the final git history. > block.c | 117 +++++++++++++++++++++++++++++++++++++++++= ++++++++ > include/block/block.h | 9 ++++ > 2 files changed, 126 insertions(+), 0 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigF55754F1AF5B49C0FCCEFC45 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ7ZMpAAoJEKeha0olJ0NqdGgIAJFXgrexq4fBBJM5PYYTZq/D G26n/Z6EQJii/PITWtUf0Hb3FoRQJN7NsBmUMSfCE1T0uXhy1VuQ45jyvIDnSbN/ l6dJG5QnFiPUMgkXkPS8t4A/SP54aZdrfJn+G1WCUDhLsY2UQF++eO6HisV85Eod DnWQ828jImPnSXAx1bzJsWmwQyI7r/UkbNa2LZWsd5eWkoNAtK55jlYtZWT4RnlP aBD0X1c7CC6ALfnq3NR2M9d8G3P7nV8XG84HO0Xw04d17UgpnyqIgyUJ1adsa0Mk e2/YaK3CYW7YQgU31OZoaoEC8BoyJc+JFg2s/4PZbSmVzMRXbh32kr7B5Kv2Q14= =YemG -----END PGP SIGNATURE----- --------------enigF55754F1AF5B49C0FCCEFC45--