From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55363) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TszEm-0005Ta-EC for qemu-devel@nongnu.org; Wed, 09 Jan 2013 12:14:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TszEk-0003Lg-Pj for qemu-devel@nongnu.org; Wed, 09 Jan 2013 12:14:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:10340) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TszEk-0003LS-Ic for qemu-devel@nongnu.org; Wed, 09 Jan 2013 12:14:46 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r09HEjRv004827 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 9 Jan 2013 12:14:46 -0500 Message-ID: <50EDA585.5080503@redhat.com> Date: Wed, 09 Jan 2013 10:14:45 -0700 From: Eric Blake MIME-Version: 1.0 References: <1357566928-25361-1-git-send-email-kraxel@redhat.com> <1357566928-25361-5-git-send-email-kraxel@redhat.com> In-Reply-To: <1357566928-25361-5-git-send-email-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigDB68E0C0D28A2A110DC2AE8F" Subject: Re: [Qemu-devel] [PATCH 04/11] chardev: add qmp hotplug commands, with null chardev support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigDB68E0C0D28A2A110DC2AE8F Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/07/2013 06:55 AM, Gerd Hoffmann wrote: > Add chardev-add and chardev-remove qmp commands. Hotplugging > a null chardev is supported for now, more will be added later. >=20 > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json | 32 ++++++++++++++++++++++++++++++++ q> qemu-char.c | 39 +++++++++++++++++++++++++++++++++++++++ > qmp-commands.hx | 50 ++++++++++++++++++++++++++++++++++++++++++++++= ++++ > 3 files changed, 121 insertions(+), 0 deletions(-) > +## > +# @chardev-add: > +# > +# Add a file chardev > +# > +# @id: the chardev's ID, must be unique > +# @backend: backend type and parameters > +# > +# Returns: Nothing on success > +# > +# Since: 1.4 > +## > +{ 'type': 'ChardevDummy', 'data': { } } > + > +{ 'union': 'ChardevBackend', 'data': { 'null' : 'ChardevDummy' } } Don't we usually document types independently from their usage, so that they aren't appearing in between the documentation for chardev-add and its actual implementation? > + > +{ 'command': 'chardev-add', 'data': {'id' : 'str', > + 'backend' : 'ChardevBackend' } } > + > +SQMP > +chardev-add > +---------------- > + > +Add a chardev. > + > +Arguments: > + > +- "id": the chardev's ID, must be unique (json-string) > +- "backend": chardev backend type + parameters > + > +Example: > + > +-> { "execute" : "chardev-add", > + "arguments" : { "id" : "foo", > + FIXME } } > +<- { "return": {} } Let's get that FIXME dealt with: -> { "execute" : "chardev-add", "arguments" : { "id" : "foo", "backend" : { "type" : "null" } } } <- { "return": {} } if I'm reading the spec correctly. Or does it have to be more verbose? -> { "execute" : "chardev-add", "arguments" : { "id" : "foo", "backend" : { "type" : "null", "data" : {} } } } <- { "return": {} } --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigDB68E0C0D28A2A110DC2AE8F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ7aWFAAoJEKeha0olJ0NqSqcH/jHUl7Acv6lXelNMe0sWhaqT HfuDpa8B0GXtLaitKS9rkuKaP4WK0btBjjSGlUThw8K0A696abPBQhySzu2gAdVF FfD7qkKBoSb1HZup8OCLfpIPgaKUHasN1SPvagfBOo0NQpbI/kvB8psoAdbAEwHf 5haBoeLpyrNxGnl0Ffnc8qhzi3Rvd66WSWzoj6GGnW0rnpcku+t5pcpdCFrNyipN 1yAGtsiUREVi0/TM2kydPhu/R4uDwK4tqd6BivdB+DffeqP5nfwYU3mfvyngjIlJ Wu4AXidSjjDbw+AzJ1X+NlhKQGNLz/ZubQsPTtw6OkM/TzPOqX1yuAgt1YUlaok= =Ky8e -----END PGP SIGNATURE----- --------------enigDB68E0C0D28A2A110DC2AE8F--