From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34812)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1Tt3RV-0000Eh-Gv
	for qemu-devel@nongnu.org; Wed, 09 Jan 2013 16:44:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1Tt3RU-0008F6-Dg
	for qemu-devel@nongnu.org; Wed, 09 Jan 2013 16:44:13 -0500
Received: from greensocs.com ([87.106.252.221]:47053
	helo=s15328186.onlinehome-server.info)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1Tt3RU-0008Ey-7R
	for qemu-devel@nongnu.org; Wed, 09 Jan 2013 16:44:12 -0500
Message-ID: <50EDE4A7.1050800@greensocs.com>
Date: Wed, 09 Jan 2013 22:44:07 +0100
From: =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= <fred.konrad@greensocs.com>
MIME-Version: 1.0
References: <1357584074-10852-1-git-send-email-fred.konrad@greensocs.com>
	<1357584074-10852-58-git-send-email-fred.konrad@greensocs.com>
	<CAAu8pHtPLYv0E_stAQLh=R2x88QtrJYx8Tj2mj8zs7h0y6X_zw@mail.gmail.com>
In-Reply-To: <CAAu8pHtPLYv0E_stAQLh=R2x88QtrJYx8Tj2mj8zs7h0y6X_zw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 57/61] virtio : remove the function pointer.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, e.voevodin@samsung.com, mst@redhat.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, agraf@suse.de, cornelia.huck@de.ibm.com, aneesh.kumar@linux.vnet.ibm.com, stefanha@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, afaerber@suse.de

On 09/01/2013 21:40, Blue Swirl wrote:
> On Mon, Jan 7, 2013 at 6:41 PM,  <fred.konrad@greensocs.com> wrote:
>> From: KONRAD Frederic <fred.konrad@greensocs.com>
>>
>> This remove the function pointer in VirtIODevice, and use only
>> VirtioDeviceClass function pointer. It should be applied after all
>> the device have been refactored.
>>
>> Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>
>> ---
>>   hw/9pfs/virtio-9p-device.c |  2 --
>>   hw/virtio-balloon.c        |  8 --------
>>
>> -        vdev->set_config(vdev, vdev->config);
>> +    if (k->set_config)
> Still this one...
> and here the braces are missing.
>
yes, I fixed these in the newpatch-set (there are in the 3rd part).

Any idea about why checkpatch.pl didn't spot them ?
Do I use it wrong ?

Thanks,
Fred