From: Hans de Goede <hdegoede@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 31/32] usbredir: Add support for buffered bulk input (v2)
Date: Wed, 09 Jan 2013 23:04:38 +0100 [thread overview]
Message-ID: <50EDE976.1000309@redhat.com> (raw)
In-Reply-To: <CAAu8pHv3kNkd8ddb1kf-McYJmpqHVheYstkBdB5e8nCxxcbE5A@mail.gmail.com>
Hi,
On 01/09/2013 09:52 PM, Blue Swirl wrote:
<snip>
>> diff --git a/hw/usb/quirks-ftdi-ids.h b/hw/usb/quirks-ftdi-ids.h
>> new file mode 100644
>> index 0000000..57c12ef
>> --- /dev/null
>> +++ b/hw/usb/quirks-ftdi-ids.h
>> @@ -0,0 +1,1255 @@
>> +/*
>> + * vendor/product IDs (VID/PID) of devices using FTDI USB serial converters.
>> + * Please keep numerically sorted within individual areas, thanks!
>> + *
>> + * Philipp Gühring - pg@futureware.at - added the Device ID of the USB relais
>> + * from Rudolf Gugler
>
> License information is missing.
>
> Where is this file coming from, Linux?
Yes, it is a one on one copy of linux/drivers/usb/serial/ftdi_sio_ids.h,
so I did not think it would be a good idea to simply slap a copyright header on top
...
One could argue it is an integral part of linux/drivers/usb/serial/ftdi_sio.c and use
the copy right headers from there.
> Should we use linux-headers instead?
Since this is a copy of an internal kernel header, rather then of one from the
linux/include/linux or linux/include/asm "public" hierarchies it seemed wrong to me to
use linux-headers for this.
Regards,
Hans
next prev parent reply other threads:[~2013-01-09 22:27 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 13:14 [Qemu-devel] [PULL 00/32] usb patch queue Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 01/32] ehci: Add a ehci_writeback_async_complete_packet helper function Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 02/32] ehci: Add ehci_verify_qh and ehci_verify_qtd helper functions Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 03/32] ehci: Verify guest does not change the token of inflight qtd-s Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 04/32] ehci: Move get / put_dwords upwards Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 05/32] ehci: writeback_async_complete_packet: verify qh and qtd Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 06/32] ehci: Verify qtd for async completed packets Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 07/32] ehci: Add an ehci_get_pid helper function Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 08/32] ehci: Verify a queue's ep direction does not change Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 09/32] ehci: Use uframe precision for interrupt threshold checking (v2) Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 10/32] ehci: Further speedup rescanning if async schedule after raising an interrupt Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 11/32] ehci: Don't call commit_irq after raising PCD Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 12/32] uhci: Fix 1 ms delay in interrupt reporting to the guest Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 13/32] uhci: Fix pending interrupts getting lost on migration Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 14/32] uhci: Add a QH_VALID define Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 15/32] uhci: Limit amount of frames processed in one go Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 16/32] uhci: Maximize how many frames we catch up when behind Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 17/32] hid: Change idle handling to use a timer Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 18/32] usb: Fix usb_ep_find_packet_by_id Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 19/32] usb: Add an usb_device_ep_stopped USBDevice method Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 20/32] usbredir: Add an usbredir_stop_ep helper function Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 21/32] usbredir: Add USBEP2I and I2USBEP helper macros Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 22/32] usbredir: Add ep_stopped USBDevice method Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 23/32] usbredir: Verify we have 32 bits bulk length cap when redirecting to xhci Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 24/32] usbredir: Add usbredir_init_endpoints() helper Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 25/32] usb-redir: Add debugging to bufpq save / restore Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 26/32] xhci: call set-address with dummy usbpacket Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 27/32] usb/ehci: Clean up SysBus and PCI EHCI split Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 28/32] usb/ehci: Move capsbase and opregbase into SysBus EHCI class Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 29/32] usb/ehci: Add SysBus EHCI device for Exynos4210 Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 30/32] exynos4210: Add EHCI support Gerd Hoffmann
2013-01-08 13:14 ` [Qemu-devel] [PATCH 31/32] usbredir: Add support for buffered bulk input (v2) Gerd Hoffmann
2013-01-09 20:52 ` Blue Swirl
2013-01-09 22:04 ` Hans de Goede [this message]
2013-01-12 10:21 ` Blue Swirl
2013-01-08 13:14 ` [Qemu-devel] [PATCH 32/32] uhci: stop using portio lists Gerd Hoffmann
2013-01-08 20:34 ` [Qemu-devel] [PULL 00/32] usb patch queue Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EDE976.1000309@redhat.com \
--to=hdegoede@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).