From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tt4Wt-00067t-CU for qemu-devel@nongnu.org; Wed, 09 Jan 2013 17:53:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tt4Ws-0000IV-BC for qemu-devel@nongnu.org; Wed, 09 Jan 2013 17:53:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38469) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tt4Ws-0000IP-1k for qemu-devel@nongnu.org; Wed, 09 Jan 2013 17:53:50 -0500 Message-ID: <50EDF4F9.70007@redhat.com> Date: Wed, 09 Jan 2013 15:53:45 -0700 From: Eric Blake MIME-Version: 1.0 References: <1357708350-9917-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1357708350-9917-7-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1357708350-9917-7-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigDA79DC0223C35103F3DCA514" Subject: Re: [Qemu-devel] [PATCH V2 06/11] qmp: add interface query-images. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: aliguori@us.ibm.com, phrdina@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigDA79DC0223C35103F3DCA514 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/08/2013 10:12 PM, Wenchao Xia wrote: > This mirror function will return all image info including > snapshots. Now Qemu have both query-images and query-block > interfaces. >=20 > V2: > Redesign the interface, it will show related block device name now. > Added counter part in qmp-commands.hx. > Using plurals in API name. Again, patch evolution changelog belongs after the S-o-b and (first) --- line. >=20 > Signed-off-by: Wenchao Xia > --- > block.c | 19 +++++++++++++ > qapi-schema.json | 27 +++++++++++++++++++ > qmp-commands.hx | 76 ++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > 3 files changed, 122 insertions(+), 0 deletions(-) >=20 > ## > +# @DeviceImageInfo: > +# > +# Information about image used by QEMU block device s/image/an image/ > =20 > SQMP > +query-images > +----------- > + > +Show the block devices's images. s/devices's/devices'/ > + > +Each block image information is stored in a json-object and the return= ed value > +is a json-array of all devices's image. s/devices's image/devices' images/ The example is nice. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigDA79DC0223C35103F3DCA514 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ7fT5AAoJEKeha0olJ0Nq1ioH/2PHfgmvSxwSEj8GL5kFKvWO ENpypLEo/8GHYhZa/9XOeQiLzd3GNkhWl4qZyX6M46TljMWrCQR2+E6x5tDFXA0e de9TnqMaiJnb0DzhlUbXYRQgfOmaOB+9CwYiK6yr1WMjG4Cje1ua87Xrqh9JsLo+ 6kU2hNCRbup+qSJ1L9f3IkQbOIA5TOzf5pc0R4Xw/Bnsv/CEGCP7ZeZpH/Rtr5jA xqWKWd8KX04p7e8KopAmPry+LHFruOoUyNdxweuLZ6EO9NqnELjCCqBZIL6WOC16 bjzSDyuCaDrb4a+ljbXwWiE3kSNldE4TblRyzAce1rnz4uFxFWNLt/5qENZyZTA= =kp4S -----END PGP SIGNATURE----- --------------enigDA79DC0223C35103F3DCA514--