From: Eric Blake <eblake@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, phrdina@redhat.com, stefanha@gmail.com,
qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com,
lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH V2 08/11] qmp: add interface query-snapshots
Date: Wed, 09 Jan 2013 16:04:16 -0700 [thread overview]
Message-ID: <50EDF770.4040501@redhat.com> (raw)
In-Reply-To: <1357708350-9917-9-git-send-email-xiawenc@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 848 bytes --]
On 01/08/2013 10:12 PM, Wenchao Xia wrote:
> This interface now return valid internal snapshots.
>
> +Each json-object contain the following:
> +
> +- "id": unique snapshot id (json-string)
> +- "name": internal snapshot name (json-string)
> +- "vm-state-size": size of the VM state (json-int)
In bytes? If not, document it (but bytes would be best).
> + {
> + "id": "2",
> + "name": "snapshot2",
> + "vm-state-size": 24000,
And if it IS in bytes, then this example value feels suspiciously small
(I don't know of any guest whose memory state occupies just 24000 bytes,
because the state includes RAM and you usually need several megabytes of
RAM as a minimum size).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2013-01-09 23:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 5:12 [Qemu-devel] [PATCH V2 00/11] add qmp/hmp interfaces for snapshot info Wenchao Xia
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 01/11] qemu-img: remove unused parameter in collect_image_info() Wenchao Xia
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 02/11] block: add bdrv_get_filename() function Wenchao Xia
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 03/11] block: add snapshot and image info query function Wenchao Xia
2013-01-09 15:56 ` Eric Blake
2013-01-10 5:43 ` Wenchao Xia
2013-01-10 13:36 ` Eric Blake
2013-01-11 3:18 ` Wenchao Xia
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 04/11] qemu-img: switch image retrieving function Wenchao Xia
2013-01-09 16:27 ` Eric Blake
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 05/11] block: rename bdrv_query_info to bdrv_query_block_info Wenchao Xia
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 06/11] qmp: add interface query-images Wenchao Xia
2013-01-09 22:53 ` Eric Blake
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 07/11] block: export function bdrv_find_snapshot() Wenchao Xia
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 08/11] qmp: add interface query-snapshots Wenchao Xia
2013-01-09 23:04 ` Eric Blake [this message]
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 09/11] hmp: export function hmp_handle_error() Wenchao Xia
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 10/11] hmp: retrieve info from qmp for snapshot info Wenchao Xia
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 11/11] hmp: show snapshot on single block device Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EDF770.4040501@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=phrdina@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).