From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tt4h5-0000QS-49 for qemu-devel@nongnu.org; Wed, 09 Jan 2013 18:04:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tt4h3-0002lP-TC for qemu-devel@nongnu.org; Wed, 09 Jan 2013 18:04:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tt4h3-0002lG-Kg for qemu-devel@nongnu.org; Wed, 09 Jan 2013 18:04:21 -0500 Message-ID: <50EDF770.4040501@redhat.com> Date: Wed, 09 Jan 2013 16:04:16 -0700 From: Eric Blake MIME-Version: 1.0 References: <1357708350-9917-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1357708350-9917-9-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1357708350-9917-9-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigCFE7CD22E7C6057DA57757F6" Subject: Re: [Qemu-devel] [PATCH V2 08/11] qmp: add interface query-snapshots List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: aliguori@us.ibm.com, phrdina@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigCFE7CD22E7C6057DA57757F6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/08/2013 10:12 PM, Wenchao Xia wrote: > This interface now return valid internal snapshots. >=20 > +Each json-object contain the following: > + > +- "id": unique snapshot id (json-string) > +- "name": internal snapshot name (json-string) > +- "vm-state-size": size of the VM state (json-int) In bytes? If not, document it (but bytes would be best). > + { > + "id": "2", > + "name": "snapshot2", > + "vm-state-size": 24000, And if it IS in bytes, then this example value feels suspiciously small (I don't know of any guest whose memory state occupies just 24000 bytes, because the state includes RAM and you usually need several megabytes of RAM as a minimum size). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigCFE7CD22E7C6057DA57757F6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ7fdwAAoJEKeha0olJ0Nq/LcH/3yOy9tGapTqDzr/WFDBzTmo 1b9qVTDd/tVLyQgW4YREUukUPskf5hUo+xjEKaeYzaDH2YzIBfO9bqZA4BbyCvDg kNnFMztYac1DE68cr8Cm9s4YG87Gbwyg+/qW8y7AT2zU7FK7+xx8knDtc4+HH0DV qnoIQ0du5EB6LQQRPqci5zQtS2Uyv1OlweWrt6JFiG+HmZ3ynpa2Gh7uV9TB7UTS TCk5/QdFk2HTxhuhQEfH9iRazjbbK8dd8NKW/2ARHfowgr/6WJU3bE54Gcd5ZQ6G opTix29fQcf8Dib2t/PqObYwAZ9EF5Y7pHDKaLxJiPVSRqBbwgXm4E0s7PKq+Ww= =SPeq -----END PGP SIGNATURE----- --------------enigCFE7CD22E7C6057DA57757F6--