From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtAw2-0001wO-IP for qemu-devel@nongnu.org; Thu, 10 Jan 2013 00:44:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtAw1-0004cq-Jy for qemu-devel@nongnu.org; Thu, 10 Jan 2013 00:44:14 -0500 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:60437) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtAw0-0004cG-Q0 for qemu-devel@nongnu.org; Thu, 10 Jan 2013 00:44:13 -0500 Received: from /spool/local by e28smtp06.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 10 Jan 2013 11:12:40 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 1A7E9E004C for ; Thu, 10 Jan 2013 11:14:20 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r0A5i4iE45023336 for ; Thu, 10 Jan 2013 11:14:04 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r0A5i5FL030535 for ; Thu, 10 Jan 2013 16:44:05 +1100 Message-ID: <50EE54ED.2090403@linux.vnet.ibm.com> Date: Thu, 10 Jan 2013 13:43:09 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1357708350-9917-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1357708350-9917-4-git-send-email-xiawenc@linux.vnet.ibm.com> <50ED9329.40202@redhat.com> In-Reply-To: <50ED9329.40202@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V2 03/11] block: add snapshot and image info query function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aliguori@us.ibm.com, phrdina@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com 于 2013-1-9 23:56, Eric Blake 写道: > On 01/08/2013 10:12 PM, Wenchao Xia wrote: >> This patch added function bdrv_query_image_info() and >> bdrv_query_snapshot_infolist(), which will return info in qmp object >> format. The implemetion code are mostly copied from collect_image_info() > > > s/implemetion/implementation/ > OK. >> and collect_snapshot() in qemu-img.c. >> To help filter out snapshot info not needed, a call back function is >> added in bdrv_query_snapshot_infolist(). >> >> v2: > > Generally, the v2 information should go... > Do you know how to put change log under "---" in "git commit"? I found it inconvenient to edit every ".patch" file, so added the log directly in commit message. >> Seperate patch for adding these functions. >> Spelling fix. >> Coding style fix due to comments from Eric. >> >> Signed-off-by: Wenchao Xia >> --- > > ...here, after the S-o-b and --- separator. It is useful for email > review, but doesn't need to clutter the final git history. > >> block.c | 117 +++++++++++++++++++++++++++++++++++++++++++++++++ >> include/block/block.h | 9 ++++ >> 2 files changed, 126 insertions(+), 0 deletions(-) >> > > Reviewed-by: Eric Blake > -- Best Regards Wenchao Xia