From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtBDH-0004p4-K1 for qemu-devel@nongnu.org; Thu, 10 Jan 2013 01:02:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtBDF-0000a6-Pf for qemu-devel@nongnu.org; Thu, 10 Jan 2013 01:02:03 -0500 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:60568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtBDF-0000Zq-8W for qemu-devel@nongnu.org; Thu, 10 Jan 2013 01:02:01 -0500 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 10 Jan 2013 16:00:30 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 550382CE804F for ; Thu, 10 Jan 2013 17:01:53 +1100 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r0A61pgW64684256 for ; Thu, 10 Jan 2013 17:01:52 +1100 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r0A61pXc029185 for ; Thu, 10 Jan 2013 17:01:52 +1100 Message-ID: <50EE5937.2040208@linux.vnet.ibm.com> Date: Thu, 10 Jan 2013 14:01:27 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1357543689-11415-1-git-send-email-xiawenc@linux.vnet.ibm.com> <50EDF08E.7000402@redhat.com> In-Reply-To: <50EDF08E.7000402@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V2 00/10] snapshot: take block snapshots in unified way List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, aliguori@us.ibm.com, Pavel Hrdina , quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, dietmar@proxmox.com 于 2013-1-10 6:34, Eric Blake 写道: > On 01/07/2013 12:27 AM, Wenchao Xia wrote: >> These patch added a seperated layer to take internal or external snapshots >> in a unified way, the granularity is block device, so other functions can >> just combine the request and submit, such as group snapshot, savevm. >> >> Total goal are: >> Live back up vm in external or internal image, which need three functions: >> 1 live snapshot block device internal/external. >> 2 live save vmstate internal/external. >> 3 combination of the function unit. >> >> This serial provide part one. >> > > The design on this series needs to be coordinated with Pavel's > attempts[1] to convert the existing HMP snapshot commands into QMP. I > don't want to spend too much time reviewing two different divergent > designs that both have the same goal of finally managing snapshots under > QMP. > > [1] https://lists.gnu.org/archive/html/qemu-devel/2013-01/msg01326.html > A bit difference: This serial are taking internal/external block snapshots but Pavel's are focusing are vm whole internal snapshots. It is OK to use Pavel's interface with a mark about "internal and sync". I'd like to add new interface after vmstate live save is implemented. -- Best Regards Wenchao Xia