From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53885)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TtDlX-0005sw-VM
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 03:45:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TtDlW-0007C4-Vu
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 03:45:35 -0500
Received: from mx1.redhat.com ([209.132.183.28]:57681)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TtDlW-0007By-Nu
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 03:45:34 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0A8jY2G018053
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 10 Jan 2013 03:45:34 -0500
Message-ID: <50EE7FAC.3010009@redhat.com>
Date: Thu, 10 Jan 2013 09:45:32 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1357566928-25361-1-git-send-email-kraxel@redhat.com>
	<1357566928-25361-5-git-send-email-kraxel@redhat.com>
	<50EDA585.5080503@redhat.com>
In-Reply-To: <50EDA585.5080503@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 04/11] chardev: add qmp hotplug commands,
 with null chardev support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org

  Hi,

>> +-> { "execute"   : "chardev-add", +     "arguments" : { "id"   :
>> "foo", +                     FIXME } } +<- { "return": {} }
> 
> Let's get that FIXME dealt with:
> 
> -> { "execute" : "chardev-add", "arguments" : { "id" : "foo", 
> "backend" : { "type" : "null" } } } <- { "return": {} }
> 
> if I'm reading the spec correctly.  Or does it have to be more
> verbose?
> 
> -> { "execute" : "chardev-add", "arguments" : { "id" : "foo", 
> "backend" : { "type" : "null", "data" : {} } } } <- { "return": {}
> }

I've tested with the long form, dunno whenever the qemu marshaller
also accepts the short one.

cheers,
  Gerd