From: Gerd Hoffmann <kraxel@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 10/11] chardev: add socket chardev support to chardev-add (qmp)
Date: Thu, 10 Jan 2013 10:12:53 +0100 [thread overview]
Message-ID: <50EE8615.3050001@redhat.com> (raw)
In-Reply-To: <50EDCD28.8020505@redhat.com>
Hi,
>> -static CharDriverState *qemu_chr_open_socket(QemuOpts *opts)
>> +static CharDriverState *qemu_chr_open_socket_fd(int fd, int
>> do_nodelay, + int
>> is_listen, int is_telnet, +
>> int is_waitconnect,
>
> These three parameters sound like they might be better as 'bool'
> instead of 'int'.
Just continuing to do what the existing code did.
>> @@ -2458,10 +2536,7 @@ static CharDriverState
>> *qemu_chr_open_socket(QemuOpts *opts) if (!is_listen)
>> is_waitconnect = 0;
>>
>> - chr = g_malloc0(sizeof(CharDriverState)); - s =
>> g_malloc0(sizeof(TCPCharDriver)); - - if (is_unix) { + if
>> (is_unix) {
>
> Spurious re-indentation?
Seems so, I'll check.
cheers,
Gerd
next prev parent reply other threads:[~2013-01-10 9:12 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 13:55 [Qemu-devel] [PATCH 00/11] chardev hotplug patch series Gerd Hoffmann
2013-01-07 13:55 ` [Qemu-devel] [PATCH 01/11] chardev: add error reporting for qemu_chr_new_from_opts Gerd Hoffmann
2013-01-10 10:26 ` Paolo Bonzini
2013-01-07 13:55 ` [Qemu-devel] [PATCH 02/11] chardev: fix QemuOpts lifecycle Gerd Hoffmann
2013-01-10 10:26 ` Paolo Bonzini
2013-01-07 13:55 ` [Qemu-devel] [PATCH 03/11] chardev: reduce chardev ifdef mess a bit Gerd Hoffmann
2013-01-10 10:27 ` Paolo Bonzini
2013-01-07 13:55 ` [Qemu-devel] [PATCH 04/11] chardev: add qmp hotplug commands, with null chardev support Gerd Hoffmann
2013-01-09 17:14 ` Eric Blake
2013-01-10 8:45 ` Gerd Hoffmann
2013-01-07 13:55 ` [Qemu-devel] [PATCH 05/11] chardev: add hmp hotplug commands Gerd Hoffmann
2013-01-10 10:33 ` Paolo Bonzini
2013-01-10 10:53 ` Gerd Hoffmann
2013-01-10 10:57 ` Paolo Bonzini
2013-01-10 12:35 ` Luiz Capitulino
2013-01-07 13:55 ` [Qemu-devel] [PATCH 06/11] chardev: add file chardev support to chardev-add (qmp) Gerd Hoffmann
2013-01-09 18:12 ` Eric Blake
2013-01-10 9:10 ` Gerd Hoffmann
2013-01-10 10:35 ` Paolo Bonzini
2013-01-07 13:55 ` [Qemu-devel] [PATCH 07/11] chardev: add tty " Gerd Hoffmann
2013-01-10 10:39 ` Paolo Bonzini
2013-01-07 13:55 ` [Qemu-devel] [PATCH 08/11] chardev: add serial " Gerd Hoffmann
2013-01-10 10:38 ` Paolo Bonzini
2013-01-10 11:05 ` Gerd Hoffmann
2013-01-10 12:37 ` Gerd Hoffmann
2013-01-10 12:46 ` Paolo Bonzini
2013-01-07 13:55 ` [Qemu-devel] [PATCH 09/11] chardev: add parport " Gerd Hoffmann
2013-01-10 10:40 ` Paolo Bonzini
2013-01-07 13:55 ` [Qemu-devel] [PATCH 10/11] chardev: add socket " Gerd Hoffmann
2013-01-09 20:03 ` Eric Blake
2013-01-10 9:12 ` Gerd Hoffmann [this message]
2013-01-07 13:55 ` [Qemu-devel] [PATCH 11/11] chardev: add pty " Gerd Hoffmann
2013-01-09 17:37 ` Eric Blake
2013-01-10 9:14 ` Gerd Hoffmann
2013-01-10 10:42 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EE8615.3050001@redhat.com \
--to=kraxel@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).