From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58725)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TtEC1-0000Z7-2O
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 04:12:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TtEC0-0006BX-43
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 04:12:57 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43162)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TtEBz-0006BT-SZ
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 04:12:56 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0A9CtN7010314
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 10 Jan 2013 04:12:55 -0500
Message-ID: <50EE8615.3050001@redhat.com>
Date: Thu, 10 Jan 2013 10:12:53 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1357566928-25361-1-git-send-email-kraxel@redhat.com>
	<1357566928-25361-11-git-send-email-kraxel@redhat.com>
	<50EDCD28.8020505@redhat.com>
In-Reply-To: <50EDCD28.8020505@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 10/11] chardev: add socket chardev support
 to chardev-add (qmp)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org

  Hi,

>> -static CharDriverState *qemu_chr_open_socket(QemuOpts *opts) 
>> +static CharDriverState *qemu_chr_open_socket_fd(int fd, int
>> do_nodelay, +                                                int
>> is_listen, int is_telnet, +
>> int is_waitconnect,
> 
> These three parameters sound like they might be better as 'bool'
> instead of 'int'.

Just continuing to do what the existing code did.

>> @@ -2458,10 +2536,7 @@ static CharDriverState
>> *qemu_chr_open_socket(QemuOpts *opts) if (!is_listen) 
>> is_waitconnect = 0;
>> 
>> -    chr = g_malloc0(sizeof(CharDriverState)); -    s =
>> g_malloc0(sizeof(TCPCharDriver)); - -    if (is_unix) { +     if
>> (is_unix) {
> 
> Spurious re-indentation?

Seems so, I'll check.

cheers,
  Gerd