From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59005)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TtEDj-0001Ud-0i
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 04:14:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TtEDh-0006rg-RP
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 04:14:42 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33276)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TtEDh-0006qY-JJ
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 04:14:41 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0A9Efdr024527
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 10 Jan 2013 04:14:41 -0500
Message-ID: <50EE867F.1020809@redhat.com>
Date: Thu, 10 Jan 2013 10:14:39 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1357566928-25361-1-git-send-email-kraxel@redhat.com>
	<1357566928-25361-12-git-send-email-kraxel@redhat.com>
	<50EDAAE9.9060103@redhat.com>
In-Reply-To: <50EDAAE9.9060103@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 11/11] chardev: add pty chardev support to
 chardev-add (qmp)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org

  Hi,

> But do we really need it to be that complex?  Why not just use a
> type with an optional member, instead of going through a union:
> 
> { 'type' : 'ChardevReturn', 'data': { '*pty' : 'str' } }

Yes, should do, we don't have to pass back the chardev type here.

thanks,
  Gerd