From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51115)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TtFYc-0005Di-G9
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 05:40:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TtFYb-0005Qt-1N
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 05:40:22 -0500
Received: from mail-qc0-f176.google.com ([209.85.216.176]:38890)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TtFYa-0005Qo-UA
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 05:40:20 -0500
Received: by mail-qc0-f176.google.com with SMTP id n41so242306qco.35
	for <qemu-devel@nongnu.org>; Thu, 10 Jan 2013 02:40:20 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <50EE9A90.5060701@redhat.com>
Date: Thu, 10 Jan 2013 11:40:16 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1357566928-25361-1-git-send-email-kraxel@redhat.com>
	<1357566928-25361-10-git-send-email-kraxel@redhat.com>
In-Reply-To: <1357566928-25361-10-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 09/11] chardev: add parport chardev support
 to chardev-add (qmp)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Il 07/01/2013 14:55, Gerd Hoffmann ha scritto:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  qapi-schema.json |    3 ++-
>  qemu-char.c      |   43 +++++++++++++++++++++++++++----------------
>  2 files changed, 29 insertions(+), 17 deletions(-)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index d833385..0922823 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3037,7 +3037,8 @@
>                                     'out' : 'ChardevFileSource' } }
>  
>  { 'enum': 'ChardevPortKind', 'data': [ 'tty',
> -                                       'serial' ] }
> +                                       'serial',
> +                                       'parport' ] }

I'd say either ['tty', 'parport'] or ['serial', 'parallel'].  In the
latter case, parallel could be an alias of parport also in the QemuOpts
case.

Apart from this,

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo

>  
>  { 'type': 'ChardevPort', 'data': { 'device' : 'ChardevFileSource',
>                                     'type'   : 'ChardevPortKind'} }
> diff --git a/qemu-char.c b/qemu-char.c
> index 4232fea..5cbf44e 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1367,17 +1367,10 @@ static void pp_close(CharDriverState *chr)
>      qemu_chr_be_event(chr, CHR_EVENT_CLOSED);
>  }
>  
> -static CharDriverState *qemu_chr_open_pp(QemuOpts *opts)
> +static CharDriverState *qemu_chr_open_pp_fd(int fd)
>  {
> -    const char *filename = qemu_opt_get(opts, "path");
>      CharDriverState *chr;
>      ParallelCharDriver *drv;
> -    int fd;
> -
> -    TFR(fd = qemu_open(filename, O_RDWR));
> -    if (fd < 0) {
> -        return NULL;
> -    }
>  
>      if (ioctl(fd, PPCLAIM) < 0) {
>          close(fd);
> @@ -1441,16 +1434,9 @@ static int pp_ioctl(CharDriverState *chr, int cmd, void *arg)
>      return 0;
>  }
>  
> -static CharDriverState *qemu_chr_open_pp(QemuOpts *opts)
> +static CharDriverState *qemu_chr_open_pp_fd(int fd)
>  {
> -    const char *filename = qemu_opt_get(opts, "path");
>      CharDriverState *chr;
> -    int fd;
> -
> -    fd = qemu_open(filename, O_RDWR);
> -    if (fd < 0) {
> -        return NULL;
> -    }
>  
>      chr = g_malloc0(sizeof(CharDriverState));
>      chr->opaque = (void *)(intptr_t)fd;
> @@ -2750,6 +2736,22 @@ fail:
>      return NULL;
>  }
>  
> +#ifdef HAVE_CHARDEV_PARPORT
> +
> +static CharDriverState *qemu_chr_open_pp(QemuOpts *opts)
> +{
> +    const char *filename = qemu_opt_get(opts, "path");
> +    int fd;
> +
> +    fd = qemu_open(filename, O_RDWR);
> +    if (fd < 0) {
> +        return NULL;
> +    }
> +    return qemu_chr_open_pp_fd(fd);
> +}
> +
> +#endif
> +
>  static const struct {
>      const char *name;
>      CharDriverState *(*open)(QemuOpts *opts);
> @@ -3053,6 +3055,15 @@ static CharDriverState *qmp_chardev_open_port(ChardevPort *port, Error **errp)
>          }
>          return qemu_chr_open_tty_fd(fd);
>  #endif
> +#ifdef HAVE_CHARDEV_PARPORT
> +    case CHARDEV_PORT_KIND_PARPORT:
> +        flags = O_RDWR;
> +        fd = qmp_chardev_open_file_source(port->device, flags, errp);
> +        if (error_is_set(errp)) {
> +            return NULL;
> +        }
> +        return qemu_chr_open_pp_fd(fd);
> +#endif
>      default:
>          error_setg(errp, "unknown chardev port (%d)", port->type);
>          return NULL;
>