From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Lieven <pl@dlhnet.de>
Cc: kwolf@redhat.com, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] block: init bs->io_base correctly to avoid locking
Date: Thu, 10 Jan 2013 11:55:16 +0100 [thread overview]
Message-ID: <50EE9E14.8080206@redhat.com> (raw)
In-Reply-To: <45632759-2B75-4F8B-9468-444F7ADC2210@dlhnet.de>
Il 10/01/2013 11:52, Peter Lieven ha scritto:
>> > Also, perhaps you can just call
>> >
>> > bdrv_exceed_io_limits(bs, 0, 0, NULL);
> won`t this segfault if only one of bps or ions limit is set?
> in this case it reads wait before returning false in
> bdrv_exceed_{bps,iops}_limits().
I didn't see any accesses that aren't checked with "if (wait)". Am I
blind? :)
Paolo
next prev parent reply other threads:[~2013-01-10 10:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 9:21 [Qemu-devel] [PATCH] block: init bs->io_base correctly to avoid locking Peter Lieven
2013-01-10 10:19 ` Paolo Bonzini
2013-01-10 10:52 ` Peter Lieven
2013-01-10 10:55 ` Paolo Bonzini [this message]
2013-01-10 11:02 ` Peter Lieven
2013-01-10 10:45 ` Markus Armbruster
2013-01-10 10:55 ` Paolo Bonzini
2013-01-10 11:52 ` Markus Armbruster
2013-01-10 11:57 ` Peter Lieven
2013-01-10 12:09 ` Paolo Bonzini
2013-01-10 12:12 ` Peter Lieven
2013-01-10 12:15 ` Paolo Bonzini
2013-01-10 12:26 ` Peter Lieven
2013-01-10 12:58 ` Peter Lieven
2013-01-10 13:29 ` Paolo Bonzini
2013-01-10 10:59 ` Peter Lieven
2013-01-10 11:17 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EE9E14.8080206@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=pl@dlhnet.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).