From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55817)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TtFp5-0006p8-PV
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 05:57:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TtFp3-0001WR-Ku
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 05:57:23 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39932)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TtFp3-0001W9-Dr
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 05:57:21 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0AAvKJH018117
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 10 Jan 2013 05:57:20 -0500
Message-ID: <50EE9E8E.20003@redhat.com>
Date: Thu, 10 Jan 2013 11:57:18 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1357566928-25361-1-git-send-email-kraxel@redhat.com>
	<1357566928-25361-6-git-send-email-kraxel@redhat.com>
	<50EE98FF.3090607@redhat.com> <50EE9DA7.3040006@redhat.com>
In-Reply-To: <50EE9DA7.3040006@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 05/11] chardev: add hmp hotplug commands
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Il 10/01/2013 11:53, Gerd Hoffmann ha scritto:
>> > 
>> > This ought to use qmp_chardev_add and a generic opts->ChardevBackend
>> > conversion.
>> > 
>> > But IMHO, this kind of intermediate conversion is okay, with the
>> > "correct" thing deferred; being able to play with hotplug from HMP is
>> > worth the small wart.  It's really Luiz's decision, so I'm not giving
>> > the reviewed-by (yet).
> Once qmp_chardev_add() can handle everything supported by
> qemu_chr_new_from_opts we can flip over, make qmp_chardev_add the
> primary interface and qemu_chr_new_from_opts legacy (which then does the
> opts->ChardevBackend conversion and calls qmp_chardev_add).
> 
> We are not there yet, even with the full series applied.

Yup.  Strange ones like msmouse, braille, etc. are missing.

> And even when we arrive there some day we don't have to touch
> hmp_chardev_add when making the switch ;)

Indeed.

Paolo