From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtIPM-0004oa-1p for qemu-devel@nongnu.org; Thu, 10 Jan 2013 08:43:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtIPK-0005DH-TF for qemu-devel@nongnu.org; Thu, 10 Jan 2013 08:42:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:62253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtIPK-0005D7-LI for qemu-devel@nongnu.org; Thu, 10 Jan 2013 08:42:58 -0500 Message-ID: <50EEC3C0.6030305@redhat.com> Date: Thu, 10 Jan 2013 06:36:00 -0700 From: Eric Blake MIME-Version: 1.0 References: <1357708350-9917-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1357708350-9917-4-git-send-email-xiawenc@linux.vnet.ibm.com> <50ED9329.40202@redhat.com> <50EE54ED.2090403@linux.vnet.ibm.com> In-Reply-To: <50EE54ED.2090403@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigF13FD10A1B66CAC3AA00FEA2" Subject: Re: [Qemu-devel] [PATCH V2 03/11] block: add snapshot and image info query function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: aliguori@us.ibm.com, phrdina@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF13FD10A1B66CAC3AA00FEA2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/09/2013 10:43 PM, Wenchao Xia wrote: >>> >>> v2: >> >> Generally, the v2 information should go... >> > Do you know how to put change log under "---" in "git commit"? > I found it inconvenient to edit every ".patch" file, so added the > log directly in commit message. Sure - manually put a --- as part of your commit message. 'git am' doesn't care if there is more than one ---. It does mean that you have to float your S-o-b higher by hand, but doing it at commit time is easier than doing post-editing of every .patch file at send-email time. Also, if you are editing a v2 of an existing series, you probably already have a S-o-b line in the commit message that you are amending, making it easy to scroll to the bottom, add ---, and then your v2 info. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigF13FD10A1B66CAC3AA00FEA2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ7sPAAAoJEKeha0olJ0NqxbQH/0c04R8Ivj+Y6I9S9gs1HddT y8TpI/iFVkk3dFvwmpGh/4pR8zFKZ8+GXAjIlNvc36gtL4i10+/4SQh2fh7kOI+4 SyPNAnMlIIhz2/bd4Unb8mx9pP79pQ/kPC4f+ccwaqNF/2T79iVhH/wA7Ty7A/pr Mn/SWoqApXUBl5m8I+T6c+DHYzmy8oJ39DMKaSiivhTWLVenPYU/z166ii10a5Pi howQfhoyUtH4t1jBgLRa86bbc2cWe6eEkj3edzKoo7Dsiobs/V83ShSXN/3zyt5L Av6amzIJlw8r7rYl/D9BXil0GIflerOMMXRTnNKDZWrCkGmg1RLAJsYtI0tYM2w= =J1sI -----END PGP SIGNATURE----- --------------enigF13FD10A1B66CAC3AA00FEA2--