From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51126)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TtJGs-0003TK-ED
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 09:38:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TtJGm-0003yf-W9
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 09:38:16 -0500
Received: from mx1.redhat.com ([209.132.183.28]:21587)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TtJGm-0003yY-O5
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 09:38:12 -0500
Message-ID: <50EED24C.3040900@redhat.com>
Date: Thu, 10 Jan 2013 15:38:04 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1355761490-10073-1-git-send-email-pbonzini@redhat.com>
	<877gnovmgj.fsf@codemonkey.ws> <50ED3971.5030600@redhat.com>
	<CAFEAcA-z9PbczysdRL7U__0-vrFko2ffvuLRTFsv-YP4CB7Ytw@mail.gmail.com>
	<50EEAA5F.8060900@redhat.com>
	<CAFEAcA9EurBMg06ozPgi1yn4gv7FdwBDbzRF-+DFx3Z8-D0Aow@mail.gmail.com>
	<50EEB045.6080908@redhat.com>
	<CAFEAcA9PJn1eku4hXp-_LWRju1vOVPs4GejMhkpwLiGy53By_w@mail.gmail.com>
	<87a9shw2ek.fsf@codemonkey.ws>
In-Reply-To: <87a9shw2ek.fsf@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more
 clear and consistent, reset qbuses under virtio devices
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, mst@redhat.com

Il 10/01/2013 15:14, Anthony Liguori ha scritto:
> What I would propose is that we:
> 
>   s/DeviceState::reset/DeviceState::hard_reset/g
> 
> Then introduce PCIDevice::soft_reset.  We can convert the PCI layer to
> call soft_reset() instead of hard_reset.
> 
> Over time, it would be great if we could find a way to implement
> hard_reset in terms of device destruction/recreation but we're not there
> yet.
> 
> I think the reset/hard_reset rename can be done via sed mostly.
> 
> Would this solve the bug that you're trying to fix Michael/Paolo?

I can fix the bug easily just in virtio-scsi.  I don't want anywone to
trip on it again due to false expectations about reset, though.

Paolo