From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtLUl-0001Gf-Rl for qemu-devel@nongnu.org; Thu, 10 Jan 2013 12:00:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtLUe-0008Pm-CJ for qemu-devel@nongnu.org; Thu, 10 Jan 2013 12:00:47 -0500 Received: from cantor2.suse.de ([195.135.220.15]:51503 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtLUe-0008Ne-3X for qemu-devel@nongnu.org; Thu, 10 Jan 2013 12:00:40 -0500 Message-ID: <50EEF3A9.4050909@suse.de> Date: Thu, 10 Jan 2013 18:00:25 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1355918961-3817-1-git-send-email-julien.grall@citrix.com> <20130110160203.GA12161@stefanha-thinkpad.redhat.com> In-Reply-To: <20130110160203.GA12161@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Bug 108996 V2] hw/dma.c: Fix converting of ioport_register* to MemoryRegion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, gson@gson.org, 1089996@bugs.launchpad.net, mtosatti@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, Julien Grall , hpoussin@reactos.org, stefanha@redhat.com Am 10.01.2013 17:02, schrieb Stefan Hajnoczi: > On Wed, Dec 19, 2012 at 12:09:21PM +0000, Julien Grall wrote: >> The commit 582299336879504353e60c7937fbc70fea93f3da introduced a 1-shi= ft for >> some offset in dma emulation. >> >> Before the previous commit, which converted ioport_register_* to Memor= yRegion, >> the DMA controller registered 8 ioports with the following formula: >> base + ((8 + i) << d->shift) where 0 <=3D i < 8 >> When an IO occured within a Memory Region, DMA callback receives an of= fset >> relative to the started address. Here the started address is: >> base + (8 << d->shift). >> The offset should be: (i << d->shift). After the shift is reverted, th= e offset >> are 0..7 not 1..8. >> >> Cc: 1089996@bugs.launchpad.net >> Reviewed-by: Andreas F=E4rber >> Reported-by: Andreas Gustafsson >> Signed-off-by: Julien Grall >> --- >> >> Modification between V1 and V2: >> * Modify the commit message to explain the problem. >> >> hw/dma.c | 22 +++++++++++----------- >> 1 file changed, 11 insertions(+), 11 deletions(-) >=20 > This patch resolves "dma: unknown iport 0" warnings for my Windows 8 gu= est. >=20 > Tested-by: Stefan Hajnoczi If you don't want to queue it for the trivial tree, I'll queue it together with Herv=E9's conversions. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg