From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34169)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1TtNq6-0004Q2-Pm
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 14:30:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1TtNq4-0001B2-Nh
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 14:30:58 -0500
Received: from smtp1-g21.free.fr ([2a01:e0c:1:1599::10]:52320)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1TtNq4-00019Y-3g
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 14:30:56 -0500
Message-ID: <50EF16DB.6010606@reactos.org>
Date: Thu, 10 Jan 2013 20:30:35 +0100
From: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>
MIME-Version: 1.0
References: <1357334986-13941-1-git-send-email-hpoussin@reactos.org>
	<1357334986-13941-5-git-send-email-hpoussin@reactos.org>
	<50EEF938.9000309@suse.de>
In-Reply-To: <50EEF938.9000309@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 04/10] sun4u: create VGA card after ISA bus
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

Andreas F=C3=A4rber a =C3=A9crit :
> Am 04.01.2013 22:29, schrieb Herv=C3=A9 Poussineau:
>> Signed-off-by: Herv=C3=A9 Poussineau <hpoussin@reactos.org>
>> ---
>>  hw/sun4u.c |    3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> Doesn't look wrong to me, cc'ing Blue. I figure this is for 07/10,
> which switches to isa_register_portio_list().

Indeed.
ISA bus is created in pci_ebus_init(). VGA card registers some ISA I/O=20
ports, so an ISA bus must be present.

Indeed.

>=20
> Andreas
>=20
>> diff --git a/hw/sun4u.c b/hw/sun4u.c
>> index cbfd217..c9150ad 100644
>> --- a/hw/sun4u.c
>> +++ b/hw/sun4u.c
>> @@ -825,11 +825,12 @@ static void sun4uv_init(MemoryRegion *address_sp=
ace_mem,
>>      ivec_irqs =3D qemu_allocate_irqs(cpu_set_ivec_irq, cpu, IVEC_MAX)=
;
>>      pci_bus =3D pci_apb_init(APB_SPECIAL_BASE, APB_MEM_BASE, ivec_irq=
s, &pci_bus2,
>>                             &pci_bus3, &pbm_irqs);
>> -    pci_vga_init(pci_bus);
>> =20
>>      // XXX Should be pci_bus3
>>      isa_bus =3D pci_ebus_init(pci_bus, -1, pbm_irqs);
>> =20
>> +    pci_vga_init(pci_bus);
>> +
>>      i =3D 0;
>>      if (hwdef->console_serial_base) {
>>          serial_mm_init(address_space_mem, hwdef->console_serial_base,=
 0,
>>
>=20
>=20