From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtNss-0006EX-Im for qemu-devel@nongnu.org; Thu, 10 Jan 2013 14:33:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtNsq-0001ag-On for qemu-devel@nongnu.org; Thu, 10 Jan 2013 14:33:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:30448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtNsq-0001aa-Fz for qemu-devel@nongnu.org; Thu, 10 Jan 2013 14:33:48 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0AJXlJR028166 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 10 Jan 2013 14:33:47 -0500 Message-ID: <50EF1799.80303@redhat.com> Date: Thu, 10 Jan 2013 12:33:45 -0700 From: Eric Blake MIME-Version: 1.0 References: <1357827786-14624-1-git-send-email-kraxel@redhat.com> <1357827786-14624-7-git-send-email-kraxel@redhat.com> In-Reply-To: <1357827786-14624-7-git-send-email-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigCC3EA132C2514EAA5579BB26" Subject: Re: [Qemu-devel] [PATCH v2 06/10] chardev: add file chardev support to chardev-add (qmp) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigCC3EA132C2514EAA5579BB26 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/10/2013 07:23 AM, Gerd Hoffmann wrote: > Add support for file chardevs. Output file is mandatory, > input file is optional. >=20 > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json | 13 ++++++++++- > qemu-char.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > qmp-commands.hx | 8 ++++++- > 3 files changed, 80 insertions(+), 2 deletions(-) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 53d4b9e..7930139 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3019,6 +3019,16 @@ > { 'command': 'nbd-server-stop' } > =20 > ## > +# @ChardevFile: Should you mention '@in: #optional' and '@out:' in any further detail? > +# > +# Configuration info for file chardevs. > +# > +# Since: 1.4 > +## > +{ 'type': 'ChardevFile', 'data': { '*in' : 'str', > + 'out' : 'str' } } Hmm; here you document ChardevFile as a separate type, but you didn't document ChardevDummy in patch 4/10. > +#ifdef _WIN32 > + > +#else /* WIN32 */ Wouldn't this be /* !_WIN32 */? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigCC3EA132C2514EAA5579BB26 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ7xeZAAoJEKeha0olJ0NqowkIALBlGlUHycrXr91LCBywlNs2 U5zToQnxrbvRkVUbB6H2783WM6p1qCnO+Db88GEdpJvD+iUDaDogcZ1tBc/RpO0p MKdxtu57+/0eTmqrVXAc1LxF7kBYj2qQ54tCShsTXZN468DoxCq6fSY/m0N0RDhw n2F3WG6ez55kACQ/HT7R2v109t07UYSOBQ8Xe2cjx4rZeD6L5wMkyCQPXpGpAS8V KdbT8KgcBgSrubgFzQ8YlhGuLSzn8BSf1eR6xVk1K+Kv5XUhDUGGKpe3fKidTE/C ZpExYcOKAKyhpeCuoxY4ldPUDm/Y5SIqzHvPissfhbCzQUCtjnzUkNnvvR1HIB4= =CZ6l -----END PGP SIGNATURE----- --------------enigCC3EA132C2514EAA5579BB26--