From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtO0Z-0000WG-Iw for qemu-devel@nongnu.org; Thu, 10 Jan 2013 14:41:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtO0X-0003fk-S4 for qemu-devel@nongnu.org; Thu, 10 Jan 2013 14:41:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29192) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtO0X-0003f9-Ja for qemu-devel@nongnu.org; Thu, 10 Jan 2013 14:41:45 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0AJfiYp003344 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 10 Jan 2013 14:41:45 -0500 Message-ID: <50EF1977.9020709@redhat.com> Date: Thu, 10 Jan 2013 12:41:43 -0700 From: Eric Blake MIME-Version: 1.0 References: <1357827786-14624-1-git-send-email-kraxel@redhat.com> <1357827786-14624-9-git-send-email-kraxel@redhat.com> In-Reply-To: <1357827786-14624-9-git-send-email-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig7611A85CA4C352B2089742C1" Subject: Re: [Qemu-devel] [PATCH v2 08/10] chardev: add parallel chardev support to chardev-add (qmp) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7611A85CA4C352B2089742C1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/10/2013 07:23 AM, Gerd Hoffmann wrote: > Also alias the old parport name to parallel for -chardev. >=20 > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json | 3 ++- > qemu-char.c | 44 ++++++++++++++++++++++++++++---------------- > qemu-options.hx | 5 ++++- > 3 files changed, 34 insertions(+), 18 deletions(-) >=20 > ## > -{ 'enum': 'ChardevPortKind', 'data': [ 'serial' ] } > +{ 'enum': 'ChardevPortKind', 'data': [ 'serial', > + 'parallel' ] } > =20 > { 'type': 'ChardevPort', 'data': { 'device' : 'str', > 'type' : 'ChardevPortKind'} } In patch 7, should the enum and type have separate documentation? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig7611A85CA4C352B2089742C1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ7xl4AAoJEKeha0olJ0NqPZkH/28mvzzNj3BXkP6g4i85rD5i yVFwwIp+hliSnHhI5Z/jB0ScB/D/WElvGjw1ywyBneDyV6TUqq9Fb2X4aaPj/g9q Zps8/Ko7YIFJmCxQszw5T9idVJHti8nKwQIPaVYl7KeEoiqFpGI75SGD9HRoXiC/ gQY/dr70TaH7GBQcwgpY8VfJmrGHGNK9WuTPueYDExUWRn69/+Ny+9Jk6W5Xy2y8 +cDCXAww3LTl42sH1fyrnV7ZOTfP0dL8bs4rcSLwaisj2tQk2q82w/OIFQoqIPPe SH79E8YzuxbZ1iHmRA8tRiEQ1Ry6oY9oGHOhGbA+6OGpoUCtrZnSBKaizGG5mKo= =qW6T -----END PGP SIGNATURE----- --------------enig7611A85CA4C352B2089742C1--