From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtO2g-0001bB-4q for qemu-devel@nongnu.org; Thu, 10 Jan 2013 14:44:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtO2d-00041A-O7 for qemu-devel@nongnu.org; Thu, 10 Jan 2013 14:43:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60085) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtO2d-00040y-GO for qemu-devel@nongnu.org; Thu, 10 Jan 2013 14:43:55 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0AJhsXP020461 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 10 Jan 2013 14:43:54 -0500 Message-ID: <50EF19FA.9030506@redhat.com> Date: Thu, 10 Jan 2013 12:43:54 -0700 From: Eric Blake MIME-Version: 1.0 References: <1357827786-14624-1-git-send-email-kraxel@redhat.com> <1357827786-14624-10-git-send-email-kraxel@redhat.com> In-Reply-To: <1357827786-14624-10-git-send-email-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig94A05EA0D7D5B28031564383" Subject: Re: [Qemu-devel] [PATCH v2 09/10] chardev: add socket chardev support to chardev-add (qmp) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig94A05EA0D7D5B28031564383 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/10/2013 07:23 AM, Gerd Hoffmann wrote: > qemu_chr_open_socket is splitted into two functions. All initializatio= n s/splitted/split/ > after creating the socket file handler is splitted away into the new and again > qemu_chr_open_socket_fd function. >=20 > chr->filename doesn't get filled from QemuOpts any more. Qemu gathers > the information using getsockname and getnameinfo instead. This way it= > will also work correctly for file handles passed via file descriptor > passing. >=20 > Finally qmp_chardev_open_socket() is the actual qmp hotplug > implementation which basically just calls socket_listen or > socket_connect and the new qemu_chr_open_socket_fd function. >=20 > Signed-off-by: Gerd Hoffmann > --- > +# @ChardevSocket: > +# > +# Configuration info for socket chardevs. Do you need any further doc details for individual fields? > +# > +# Since: 1.4 > +## > +{ 'type': 'ChardevSocket', 'data': { 'addr' : 'SocketAddress', > + '*server' : 'bool', > + '*wait' : 'bool', > + '*delay' : 'bool', > + '*telnet' : 'bool' } } > + > =20 > -static CharDriverState *qemu_chr_open_socket(QemuOpts *opts) > +static CharDriverState *qemu_chr_open_socket_fd(int fd, int do_nodelay= , > + int is_listen, int is_= telnet, > + int is_waitconnect, > + Error **errp) You didn't pick up on my v1 comment of converting these parameters to boo= l. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig94A05EA0D7D5B28031564383 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ7xn6AAoJEKeha0olJ0NqELIH/0cqP3otxTXw7GgvOnN1rZcS uY4sXE/YJu+36wgZPVyOpUf9HFddOeEtmOKm8PmnOoJJY1w1HcQO9uUvOjNuw0AB amiBhpnGVz9G6u+i2Sa9ZHd1VEvojz7825enxMqc1jdrD+VvA30EyMpZ2+M3aS49 6n9b1H5pBJsvOZSzVNocywPtepGEK0eaALZyNH4aOFkJBKchQF3P7ZEwBmEtDGR4 owg6AcLcT+xvXONuPmEUzyEAI5bAofoDszcoULn/y2dSux6aKyRmg+VkPghE0JZy hwokWQeJb/tv2N5WSTjOs3w76cVO83U1ik1cdmPmPz9JX+3QCfuisXHuPLb41Hw= =nTK3 -----END PGP SIGNATURE----- --------------enig94A05EA0D7D5B28031564383--