Re: [Qemu-devel] [PATCH v2 10/10] chardev: add pty chardev support to chardev-add (qmp)

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 984 bytes --]

On 01/10/2013 07:23 AM, Gerd Hoffmann wrote:
> The ptsname is returned directly, so there is no need to
> use query-chardev to figure the pty device path.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  qapi-schema.json |    3 ++-
>  qemu-char.c      |   13 +++++++++++++
>  qmp-commands.hx  |    5 +++++
>  3 files changed, 20 insertions(+), 1 deletions(-)

> +++ b/qmp-commands.hx
> @@ -2685,6 +2685,11 @@ Examples:
>                                     "data" : { "out" : "/tmp/bar.log" } } } }
>  <- { "return": {} }
>  
> +-> { "execute" : "chardev-add",
> +     "arguments" : { "id" : "baz",
> +                     "backend" : { "type" : "pty", "data" : {} } } }
> +<- { "return": { "pty" : "/dev/pty/42" } }

I like it.  The QMP API is looking saner now, although I still pointed
out enough questions that you might need a v3.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]