From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtO4E-0002bj-F9 for qemu-devel@nongnu.org; Thu, 10 Jan 2013 14:45:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtO4B-0004fF-NX for qemu-devel@nongnu.org; Thu, 10 Jan 2013 14:45:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:15431) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtO4B-0004f8-Dz for qemu-devel@nongnu.org; Thu, 10 Jan 2013 14:45:31 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0AJjUSF031664 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 10 Jan 2013 14:45:30 -0500 Message-ID: <50EF1A58.30807@redhat.com> Date: Thu, 10 Jan 2013 12:45:28 -0700 From: Eric Blake MIME-Version: 1.0 References: <1357827786-14624-1-git-send-email-kraxel@redhat.com> <1357827786-14624-11-git-send-email-kraxel@redhat.com> In-Reply-To: <1357827786-14624-11-git-send-email-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig9F93DEFE34B6D3E636043C79" Subject: Re: [Qemu-devel] [PATCH v2 10/10] chardev: add pty chardev support to chardev-add (qmp) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9F93DEFE34B6D3E636043C79 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/10/2013 07:23 AM, Gerd Hoffmann wrote: > The ptsname is returned directly, so there is no need to > use query-chardev to figure the pty device path. >=20 > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json | 3 ++- > qemu-char.c | 13 +++++++++++++ > qmp-commands.hx | 5 +++++ > 3 files changed, 20 insertions(+), 1 deletions(-) > +++ b/qmp-commands.hx > @@ -2685,6 +2685,11 @@ Examples: > "data" : { "out" : "/tmp/bar.log" }= } } } > <- { "return": {} } > =20 > +-> { "execute" : "chardev-add", > + "arguments" : { "id" : "baz", > + "backend" : { "type" : "pty", "data" : {} } } } > +<- { "return": { "pty" : "/dev/pty/42" } } I like it. The QMP API is looking saner now, although I still pointed out enough questions that you might need a v3. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig9F93DEFE34B6D3E636043C79 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ7xpYAAoJEKeha0olJ0NqcSwH/jnILbGv1z2tir2CLyLR+si0 NSjm4kYh7JGlO1km27aQ2Ii2pOvb1bqkJrh7mM3e8K1+N2YCqclVHyOFKchOGae7 qMmYEQ9rWUL0SiMOSewIR8AsZiv9Vq8HEP1zdukx7uX6VJOIZWTXkJi0IWxRESrS z6mg64o/bsh8J2t2brOQspYieV7EZGoGV0O+BX9d9GMYg+/NuwoSzjLUQUKk4qSC HB4b8BSqGQNSnAJl1g+VdLgn05i6dDHqH09Y/UpfWh2mFBGfw7crDAllDM6Vl0wN El0dOBar5eAjEvjwkt8trC9b0x6mqzoBxTq4yx3NFyGtVeSP6gFEkXXWpnQ6d1E= =yL8H -----END PGP SIGNATURE----- --------------enig9F93DEFE34B6D3E636043C79--