From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33015)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TtPcv-0004yz-R8
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 16:25:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TtPcs-0004xJ-NP
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 16:25:29 -0500
Received: from mail-vc0-f178.google.com ([209.85.220.178]:47504)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TtPJp-00009c-9j
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 16:05:45 -0500
Received: by mail-vc0-f178.google.com with SMTP id l6so786563vcl.37
	for <qemu-devel@nongnu.org>; Thu, 10 Jan 2013 13:05:44 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <50EF2D25.4080601@twiddle.net>
Date: Thu, 10 Jan 2013 13:05:41 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1357597486-19395-1-git-send-email-laurent@vivier.eu>
	<1357850568-7626-1-git-send-email-laurent@vivier.eu>
In-Reply-To: <1357850568-7626-1-git-send-email-laurent@vivier.eu>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH][v2] linux-user,
	alpha: l_type of fcntl() flock differs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <laurent@vivier.eu>
Cc: Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org

On 01/10/2013 12:42 PM, Laurent Vivier wrote:
> +static const bitmask_transtbl flock_tbl[] = {
> +    TRANSTBL_CONVERT(F_RDLCK),
> +    TRANSTBL_CONVERT(F_WRLCK),
> +    TRANSTBL_CONVERT(F_UNLCK),
> +    TRANSTBL_CONVERT(F_EXLCK),
> +    TRANSTBL_CONVERT(F_SHLCK),
> +    { 0, 0, 0, 0 }
> +};

Oh, I forgot to mention that you'll need to protect against the
case of F_RDLCK == 0 && TARGET_F_RDLCK == 0.  The easiest way to
handle this is place that entry last.


r~