From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48826) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtQbI-0001lV-In for qemu-devel@nongnu.org; Thu, 10 Jan 2013 17:27:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtQbC-0003Gv-7j for qemu-devel@nongnu.org; Thu, 10 Jan 2013 17:27:52 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:34160) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtQbC-0003Fx-2b for qemu-devel@nongnu.org; Thu, 10 Jan 2013 17:27:46 -0500 Message-ID: <50EF405D.2070604@codesourcery.com> Date: Thu, 10 Jan 2013 16:27:41 -0600 From: Meador Inge MIME-Version: 1.0 References: <1357854407-7093-1-git-send-email-meadori@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the appropriate signal List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, aurelien@aurel32.net On 01/10/2013 04:12 PM, Peter Maydell wrote: > This is an OS/ABI specific define, right? I don't think it > belongs in the target-mips header file. Since it only has one > user, I think you could reasonably just put it in linux-user/main.c. The enum will only be used in the MIPS CPU loop. I originally put it in target-mips/cpu.h because that is where the exception codes are defined. However, the one user argument makes sense to me. I moved the enum definition. Thanks for the review. -- Meador Inge CodeSourcery / Mentor Embedded