From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39231)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1TtV6u-0006Yo-SS
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 22:16:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1TtV6s-0006vv-I0
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 22:16:48 -0500
Received: from e28smtp08.in.ibm.com ([122.248.162.8]:59154)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1TtV6r-0006u1-Um
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 22:16:46 -0500
Received: from /spool/local
	by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <xiawenc@linux.vnet.ibm.com>;
	Fri, 11 Jan 2013 08:45:01 +0530
Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58])
	by d28dlp02.in.ibm.com (Postfix) with ESMTP id 565CB394004D
	for <qemu-devel@nongnu.org>; Fri, 11 Jan 2013 08:46:41 +0530 (IST)
Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64])
	by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r0B3GcWI33161460
	for <qemu-devel@nongnu.org>; Fri, 11 Jan 2013 08:46:39 +0530
Received: from d28av02.in.ibm.com (loopback [127.0.0.1])
	by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	r0B3GeXI008213
	for <qemu-devel@nongnu.org>; Fri, 11 Jan 2013 14:16:40 +1100
Message-ID: <50EF8407.1030101@linux.vnet.ibm.com>
Date: Fri, 11 Jan 2013 11:16:23 +0800
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1357806754-8552-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1357806754-8552-2-git-send-email-xiawenc@linux.vnet.ibm.com>
	<20130110111057.4508f8bb@doriath.home>
In-Reply-To: <20130110111057.4508f8bb@doriath.home>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH V4 1/4] HMP: add QDict to info callback
	handler
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, chenwj@iis.sinica.edu.tw, armbru@redhat.com

于 2013-1-10 21:10, Luiz Capitulino 写道:
> On Thu, 10 Jan 2013 16:32:31 +0800
> Wenchao Xia <xiawenc@linux.vnet.ibm.com> wrote:
>
>> diff --git a/monitor.c b/monitor.c
>> index 9cf419b..c7b3014 100644
>> --- a/monitor.c
>> +++ b/monitor.c
>> @@ -123,7 +123,7 @@ typedef struct mon_cmd_t {
>>       const char *help;
>>       void (*user_print)(Monitor *mon, const QObject *data);
>>       union {
>> -        void (*info)(Monitor *mon);
>> +        void (*info)(Monitor *mon, const QDict *qdict);
>>           void (*cmd)(Monitor *mon, const QDict *qdict);
>
> Is it possible to eliminate 'info' and use 'cmd' instead?
>
   yes, now info is not a special case but a sub command.
If you agree I'll delete info function.

-- 
Best Regards

Wenchao Xia