From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47043) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtYuv-00043W-DH for qemu-devel@nongnu.org; Fri, 11 Jan 2013 02:20:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtYut-0008Ea-FG for qemu-devel@nongnu.org; Fri, 11 Jan 2013 02:20:41 -0500 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:55199) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtYus-0008EA-Qd for qemu-devel@nongnu.org; Fri, 11 Jan 2013 02:20:39 -0500 Received: from /spool/local by e28smtp06.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 11 Jan 2013 12:49:03 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 7C7DD394004F for ; Fri, 11 Jan 2013 12:50:31 +0530 (IST) Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r0B7KU2948431204 for ; Fri, 11 Jan 2013 12:50:30 +0530 Received: from d28av01.in.ibm.com (loopback [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r0B7KUif014137 for ; Fri, 11 Jan 2013 07:20:31 GMT Message-ID: <50EFBD3D.2050706@linux.vnet.ibm.com> Date: Fri, 11 Jan 2013 15:20:29 +0800 From: Lei Li MIME-Version: 1.0 References: <1357466820-12860-1-git-send-email-lilei@linux.vnet.ibm.com> <1357466820-12860-2-git-send-email-lilei@linux.vnet.ibm.com> <20130109153637.GA1543@vm> In-Reply-To: <20130109153637.GA1543@vm> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] qga: add support to get host time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mdroth Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On 01/09/2013 11:36 PM, mdroth wrote: > On Sun, Jan 06, 2013 at 06:06:58PM +0800, Lei Li wrote: >> Signed-off-by: Lei Li >> --- >> qga/commands-posix.c | 18 ++++++++++++++++++ >> qga/qapi-schema.json | 17 +++++++++++++++++ >> 2 files changed, 35 insertions(+), 0 deletions(-) >> >> diff --git a/qga/commands-posix.c b/qga/commands-posix.c >> index a657201..26b0fa0 100644 >> --- a/qga/commands-posix.c >> +++ b/qga/commands-posix.c >> @@ -91,6 +91,24 @@ exit_err: >> error_set(err, QERR_UNDEFINED_ERROR); >> } >> >> +static HostTimeInfo *get_host_time(void) >> +{ > Should squash this into patch #2, since it doesn't get used > till then. Otherwise we'll break build bisection when compiling > with -Wunused/-Wall && -Werror, which is usually the default. ok, got it. Thanks! >> + int err; >> + qemu_timeval tq; >> + HostTimeInfo *host_time; >> + >> + err = qemu_gettimeofday(&tq); >> + if (err < 0) { >> + return NULL; >> + } >> + >> + host_time = g_malloc0(sizeof(HostTimeInfo)); >> + host_time->seconds = tq.tv_sec; >> + host_time->microseconds = tq.tv_usec; >> + >> + return host_time; >> +} >> + >> typedef struct GuestFileHandle { >> uint64_t id; >> FILE *fh; >> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json >> index ed0eb69..7793aff 100644 >> --- a/qga/qapi-schema.json >> +++ b/qga/qapi-schema.json >> @@ -83,6 +83,23 @@ >> { 'command': 'guest-ping' } >> >> ## >> +# @HostTimeInfo >> +# >> +# Information about host time. >> +# >> +# @seconds: "seconds" time from the host. >> +# >> +# @microseconds: "microseconds" time from the host. >> +# >> +# @utc-offset: information about utc offset. >> +# >> +# Since: 1.4 >> +## >> +{ 'type': 'HostTimeInfo', >> + 'data': { 'seconds': 'int', 'microseconds': 'int', >> + 'utc-offset': 'int' } } >> + >> +## >> # @GuestAgentCommandInfo: >> # >> # Information about guest agent commands. >> -- >> 1.7.7.6 >> -- Lei